Skip to content

OCPBUGS-103337: Fix CVE-2026-33814: Update golang.org/x/net - #295

Open
lack wants to merge 1 commit into
openshift:release-4.18from
lack:fix-cve-2026-33814-release-4.18
Open

OCPBUGS-103337: Fix CVE-2026-33814: Update golang.org/x/net#295
lack wants to merge 1 commit into
openshift:release-4.18from
lack:fix-cve-2026-33814-release-4.18

Conversation

@lack

@lack lack commented Aug 26, 2026

Copy link
Copy Markdown
Member

Update golang.org/x/net to resolve Go HTTP/2 Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame (CVE-2026-33814).

Also includes:

  • Update to go 1.25.0 and sync GOLANG_CROSS_VERSION in Makefile
  • Update vendor modules
  • hack: use go tool directive for golangci-lint and track vendor files
  • Update report-creator golden files to match new go version outputs

@openshift-ci-robot

Copy link
Copy Markdown

@lack: No Jira issue with key CVE-2026 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Update golang.org/x/net to resolve Go HTTP/2 Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame (CVE-2026-33814).

Also includes:

  • Update to go 1.25.0 and sync GOLANG_CROSS_VERSION in Makefile
  • Update vendor modules
  • hack: use go tool directive for golangci-lint and track vendor files
  • Update report-creator golden files to match new go version outputs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1782da91-8cf8-4965-8561-019c6f2ff16b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lack lack changed the title Fix CVE-2026-33814: Update golang.org/x/net OCPBUGS-103337: Fix CVE-2026-33814: Update golang.org/x/net Aug 26, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@lack: This pull request references Jira Issue OCPBUGS-103337, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-103337 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Update golang.org/x/net to resolve Go HTTP/2 Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame (CVE-2026-33814).

Also includes:

  • Update to go 1.25.0 and sync GOLANG_CROSS_VERSION in Makefile
  • Update vendor modules
  • hack: use go tool directive for golangci-lint and track vendor files
  • Update report-creator golden files to match new go version outputs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lack

lack commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

/appprove

@lack

lack commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

/retest

@lack
lack force-pushed the fix-cve-2026-33814-release-4.18 branch 2 times, most recently from 9e2f0f0 to 25ca08d Compare August 27, 2026 15:25
Update golang.org/x/net to resolve Go HTTP/2 Denial of Service via malformed
SETTINGS_MAX_FRAME_SIZE frame (CVE-2026-33814).

Also includes:
- Update to go 1.25.0 and sync GOLANG_CROSS_VERSION in Makefile
- Update vendor modules
- hack: use go tool directive for golangci-lint and track vendor files
- Update report-creator golden files to match new go version outputs
@lack
lack force-pushed the fix-cve-2026-33814-release-4.18 branch from 25ca08d to e4bcd9e Compare August 27, 2026 19:26
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown

@lack: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images e4bcd9e link true /test images
ci/prow/unit e4bcd9e link true /test unit
ci/prow/markdownlint e4bcd9e link true /test markdownlint
ci/prow/golint e4bcd9e link true /test golint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants