[WIP] OCPKUEUE-613: Install helm in Kueue DRA e2e test step for dra-example-driver validation#77988
[WIP] OCPKUEUE-613: Install helm in Kueue DRA e2e test step for dra-example-driver validation#77988anahas-redhat wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@anahas-redhat: This pull request references OCPKUEUE-613 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThe DRA e2e test chain now installs Helm v3.17.3 at runtime by downloading the Linux tarball, verifying its SHA256, extracting Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anahas-redhat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@anahas-redhat: This pull request references OCPKUEUE-613 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/step-registry/kueue-operator/test/e2e/dra/kueue-operator-test-e2e-dra-chain.yaml`:
- Line 39: The current single-line install (curl ... | tar xz -C /tmp && mv
/tmp/linux-amd64/helm /usr/local/bin/helm) lacks integrity checks; change it to
download the helm-v3.17.3-linux-amd64.tar.gz to a temp file, obtain a trusted
SHA256 (either by fetching the matching .sha256 from the Helm release or
embedding the expected hash), verify the tarball with sha256sum (or equivalent)
and abort on mismatch, and only then extract and mv the validated archive to
/usr/local/bin/helm so that extraction never runs on an unverified artifact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: b7737d6d-dcda-4518-ab5d-6cb16dc0b6e2
📒 Files selected for processing (1)
ci-operator/step-registry/kueue-operator/test/e2e/dra/kueue-operator-test-e2e-dra-chain.yaml
…r validation The DRA e2e test suite includes a vendor-neutral validation test (S5) that deploys dra-example-driver via Helm, but the CI image does not include the helm binary. Install helm v3.17.3 in the e2e-kueue-dra step before running the tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
anahas-redhat
force-pushed
the
kueue-helm
branch
from
21b2c14 to
55b6849
Compare
|
@anahas-redhat: This pull request references OCPKUEUE-613 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-kueue-operator-main-test-e2e-dra-gpu-4-21 |
|
@anahas-redhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@anahas-redhat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
The DRA e2e test suite includes a vendor-neutral validation test that deploys dra-example-driver via Helm, but the CI image does not include the helm binary.
This change installs helm v3.17.3 in the e2e-kueue-dra step before running the tests.
Testing against multiple drivers is a requirement of OCPKUEUE-574, ensuring Kueue's DRA support remains vendor-agnostic.
As a next step, the automated test will be added to the Kueue DRA test suite.
Summary by CodeRabbit
Release Notes