Skip to content

Fix OKD SCOS upgrade periodic jobs (drop openshift_installer)#77998

Open
sarthakpurohit wants to merge 1 commit intoopenshift:mainfrom
sarthakpurohit:fix-okd-upgrade-jobs
Open

Fix OKD SCOS upgrade periodic jobs (drop openshift_installer)#77998
sarthakpurohit wants to merge 1 commit intoopenshift:mainfrom
sarthakpurohit:fix-okd-upgrade-jobs

Conversation

@sarthakpurohit
Copy link
Copy Markdown
Contributor

@sarthakpurohit sarthakpurohit commented Apr 18, 2026

Fixes remaining jobs that were missed in #77943:

  • release-openshift-okd-scos-installer-e2e-aws-upgrade-from-scos-next
  • release-openshift-okd-scos-installer-e2e-gcp-upgrade-from-scos-stable
  • release-openshift-okd-scos-installer-e2e-gcp-upgrade-from-scos-next Convert from deprecated openshift_installer to steps/workflow format.

Summary by CodeRabbit

  • Chores
    • Consolidated and streamlined internal CI/CD infrastructure configurations for periodic job testing, unifying the execution model across conformance parallel testing, serial testing, upgrade testing, and cluster launch procedures. This refactoring improves consistency and maintainability of testing workflows while preserving all existing functionality and test coverage.

Fixes remaining jobs that were missed in openshift#77943:
- release-openshift-okd-scos-installer-e2e-aws-upgrade-from-scos-next
- release-openshift-okd-scos-installer-e2e-gcp-upgrade-from-scos-stable
- release-openshift-okd-scos-installer-e2e-gcp-upgrade-from-scos-next
Convert from deprecated openshift_installer to steps/workflow format.
@openshift-ci openshift-ci bot requested review from smg247 and wking April 18, 2026 08:43
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f34cc9e5-3482-4ae3-88d1-f853e559c419

📥 Commits

Reviewing files that changed from the base of the PR and between 3ecf6ba and 8f90c8c.

📒 Files selected for processing (1)
  • ci-operator/jobs/openshift/release/openshift-release-infra-periodics.yaml

Walkthrough

A CI operator configuration file was refactored to transition multiple periodic job test entries from command-based execution with openshift_installer blocks to a unified steps format using predefined workflows, preserving cluster profiles while delegating execution logic to workflow definitions.

Changes

Cohort / File(s) Summary
Periodic Job Workflow Conversion
ci-operator/jobs/openshift/release/openshift-release-infra-periodics.yaml
Reworked multiple job test entries from commands-based model with openshift_installer block to steps format. E2E parallel/serial cases now use workflow: openshift-e2e-$(CLUSTER_TYPE) patterns, upgrade cases use workflow: openshift-upgrade-$(CLUSTER_TYPE), and launch case replaced sleep command with test step referencing clusterbot-wait and E2E workflow. Cluster profiles preserved across conversions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main change: fixing OKD SCOS upgrade periodic jobs by dropping the deprecated openshift_installer format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This check validates Ginkgo test naming stability, but the PR only modifies CI/CD job configuration files without any Ginkgo test code or definitions.
Test Structure And Quality ✅ Passed This check is designed to review Ginkgo test code quality patterns, but the PR modifies only CI/CD job configuration YAML files with no Ginkgo test code.
Microshift Test Compatibility ✅ Passed PR modifies only CI/CD job configuration files converting periodic jobs from deprecated openshift_installer format to modern steps/workflow format. No new Ginkgo e2e tests are being added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This custom check for SNO test compatibility is not applicable to this PR, which only refactors CI configuration from deprecated format to newer format without adding new tests.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI/CD job configuration files, not deployment manifests or operators. No scheduling constraints or topology-dependent behaviors are introduced.
Ote Binary Stdout Contract ✅ Passed Pull request contains only YAML configuration changes for CI/CD job definitions with no Go code modifications related to OTE binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only CI job configuration files (YAML), not Ginkgo test implementations. No new test code added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot openshift-merge-bot bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 18, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@sarthakpurohit: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 18, 2026

@sarthakpurohit: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jatinsu
Copy link
Copy Markdown
Contributor

jatinsu commented Apr 18, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jatinsu, sarthakpurohit
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants