Revert "shiftstack/liveliness: skip TLS verify for dev-install CA workaround"

[dlaw4608]

Reverts #83891
New CA certs generated for mecha-central (SSL Certificate, SSL Key, SSL Root Certificate). This workaround can be removed.

Summary by CodeRabbit

The shiftstack/liveliness CI check no longer disables TLS verification in clouds.yaml. This restores certificate validation for the mecha-central OpenStack environment now that its CA certificates are available.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c14042f7-2183-45c2-97f6-22925df869cc

📥 Commits

Reviewing files that changed from the base of the PR and between 024ffcd and 4b559c2.

📒 Files selected for processing (1)

• ci-operator/step-registry/shiftstack/liveliness/shiftstack-liveliness-commands.sh

💤 Files with no reviewable changes (1)

• ci-operator/step-registry/shiftstack/liveliness/shiftstack-liveliness-commands.sh

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

Walkthrough

The ShiftStack liveliness script no longer changes the selected OpenStack cloud configuration to disable certificate verification. Proxy handling and the liveliness check remain unchanged.

Changes

ShiftStack liveliness

Layer / File(s)	Summary
Preserve certificate verification defaults ci-operator/step-registry/shiftstack/liveliness/shiftstack-liveliness-commands.sh	The script no longer uses yq to set verify to false in clouds.yaml.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4b559

This localized change removes an obsolete development-only TLS workaround; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the revert and matches the change that restores TLS verification for the ShiftStack liveliness check.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes one Bash command script only. The exact diff removes a yq TLS-verification workaround and adds no Ginkgo test declarations or test titles. Searches of the changed file and i…
Test Structure And Quality	✅ Passed	PASS — The pull request changes only ci-operator/step-registry/shiftstack/liveliness/shiftstack-liveliness-commands.sh and removes a yq command. It adds or changes no Ginkgo test code, so the list…
Microshift Test Compatibility	✅ Passed	The pull request changes only shiftstack-liveliness-commands.sh and removes the yq TLS-verification workaround. It adds no Ginkgo e2e tests, unavailable OpenShift API references, namespaces, or Mi…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request only deletes the yq TLS-verification workaround from one shell script. It adds no Ginkgo tests or test files, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only ci-operator/step-registry/shiftstack/liveliness/shiftstack-liveliness-commands.sh. The diff removes a yq command that disabled TLS verification in clouds.yaml…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only a Bash step script and removes three yq lines. It does not modify an OTE binary, Go/Ginkgo suite setup, or process-level logging. The script's existing echo sta…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS — The pull request changes only shiftstack-liveliness-commands.sh. It removes a yq command that disabled TLS verification and adds no Ginkgo tests or IPv4/external-connectivity test logic. Th…
No-Weak-Crypto	✅ Passed	PASS: The commit changes only one shell script and deletes the yq command that set clouds.yaml TLS verification to false. It adds no code or configuration using MD5, SHA1, DES, RC4, 3DES, Blowfi…
Container-Privileges	✅ Passed	PASS: The pull request changes only shiftstack-liveliness-commands.sh and removes a yq TLS verification override. The changed file adds no privileged, hostPID, hostNetwork, hostIPC, `SYS_A…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request changes only shiftstack-liveliness-commands.sh and removes the yq command that disabled TLS verification. It adds no logging or sensitive-value output. The existing echo s…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

The pull request changes one Bash command script only. The exact diff removes a yq TLS-verification workaround and adds no Ginkgo test declarations or test titles. Searches of the changed file and its liveliness step directory found no It(), Describe(), Context(), or When() calls. Therefore, the stable and deterministic test-name check is not applicable.

Full details: Test Structure And Quality

Explanation

PASS — The pull request changes only ci-operator/step-registry/shiftstack/liveliness/shiftstack-liveliness-commands.sh and removes a yq command. It adds or changes no Ginkgo test code, so the listed test-structure requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

The pull request changes only shiftstack-liveliness-commands.sh and removes the yq TLS-verification workaround. It adds no Ginkgo e2e tests, unavailable OpenShift API references, namespaces, or MicroShift-incompatible assumptions. The custom check is therefore not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only ci-operator/step-registry/shiftstack/liveliness/shiftstack-liveliness-commands.sh. The diff removes a yq command that disabled TLS verification in clouds.yaml; it does not add or modify deployment manifests, operators, controllers, replicas, affinity, topology spread, node selectors, tolerations, or disruption budgets. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only a Bash step script and removes three yq lines. It does not modify an OTE binary, Go/Ginkgo suite setup, or process-level logging. The script's existing echo statements are unchanged and are outside this check's stated scope.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The pull request changes only shiftstack-liveliness-commands.sh. It removes a yq command that disabled TLS verification and adds no Ginkgo tests or IPv4/external-connectivity test logic. The custom check is therefore not applicable.

Full details: No-Weak-Crypto

Explanation

PASS: The commit changes only one shell script and deletes the yq command that set clouds.yaml TLS verification to false. It adds no code or configuration using MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or non-constant-time secret comparison.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only shiftstack-liveliness-commands.sh and removes a yq TLS verification override. The changed file adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root-user setting. The associated step reference also contains no listed security-context settings. No explicit container-privilege failure condition was introduced.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only shiftstack-liveliness-commands.sh and removes the yq command that disabled TLS verification. It adds no logging or sensitive-value output. The existing echo statements and ./server.sh -d invocation are unchanged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@dlaw4608: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-shiftstack-ci-main-liveliness-mecha-central	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[IlanZuckerman]

/pj-rehearse periodic-ci-shiftstack-ci-main-liveliness-mecha-central

[openshift-merge-bot]

@IlanZuckerman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@dlaw4608: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[IlanZuckerman]

/pj-rehearse ack
/lgtm

[openshift-merge-bot]

@IlanZuckerman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[stephenfin]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlaw4608, IlanZuckerman, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/shiftstack/OWNERS [stephenfin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment