bgp_dt05 , iBGP for EDPM nodes - #782
Conversation
|
Skipping CI for Draft Pull Request. |
c7e6a50 to
aa60ef7
Compare
|
Build failed (check pipeline). Post ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post ✔️ noop SUCCESS in 0s |
3c095b4 to
2f61c51
Compare
|
Build failed (check pipeline). Post ✔️ noop SUCCESS in 0s |
mtomaska
changed the title
|
Build failed (check pipeline). Post ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post ✔️ noop SUCCESS in 0s |
|
recheck |
There was a problem hiding this comment.
I was able to build all of the CRs except 01_nncp.yaml which failed with:
unable to find field "spec.desiredState.interfaces.0.ipv4.address.0.ip" in replacement target
Thus, I'm requesting that be updated.
Here are the CRs from the build:
[johfulto@laptop CRs{bgp_dt05}]$ wc -l *
478 02_networking.yaml
609 03_control-plane.yaml
214 04_edpm-r0-compute-nodeset.yaml
214 05_edpm-r1-compute-nodeset.yaml
214 06_edpm-r2-compute-nodeset.yaml
204 07_edpm-r0-networker-nodeset.yaml
204 08_edpm-r1-networker-nodeset.yaml
204 09_edpm-r2-networker-nodeset.yaml
13 10_edpm-deployment.yaml
2354 total
[johfulto@laptop CRs{bgp_dt05}]$
Here is a diff of the output of bgp_dt01 compared to the output of bgp_dt05
https://gist.github.com/fultonj/a789ba08cf1a8387240496cb0bef3aba
|
This PR directly copies a lot of files from A similar thing is going on in a new PR for bgp_dt02 I asked an LLM to refactor 01, 02, and 05 by sharing a common directory for bgp. Links to refactored code and analysis are available in this gist. Thoughts? https://gist.github.com/fultonj/bf885c3b065988854b1b7da6eeb0a523 |
|
@fultonj I agree this could be refactored. I was simply following the current implementation of bgp_dt05. We also discussed this in our team meeting. We concluded that we should submit these PRs in the current state and then follow up with a refactor PR where all bgp_dt* made DRY. |
|
Want to rebase on top of [1] and make the other changes cited and then we can plan for a refactor after? [1] #791 |
f1d439f to
21d87ca
Compare
|
@fultonj refactor Jira https://redhat.atlassian.net/browse/OSPRH-34161 |
|
Next steps:
|
|
@fultonj The requested changes were already done. I amend last commit. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fultonj, mtomaska The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (gate pipeline). For information on how to proceed, see Warning: |
|
Build failed (gate pipeline). For information on how to proceed, see Warning: |
|
|
New changes are detected. LGTM label has been removed. |
edpm nodes utilize iBGP AS 65000 Related: OSPRH-32310 Assisted-By: Claude Code Signed-off-by: Miro Tomaska <mtomaska@redhat.com>
2 participants
A new bgp_dt05 example based on bgp_dt01. In this deployment all leafs and edpm nodes are on the same ASN. The number of nodes has not changed from bgp_dt01.
The control plane is using BGP to advertise control plane IPs. This topology will be used for testing BGP EVPN advertising where dataplane traffic will establish VXLAN tunnels for dataplane traffic
Depends-On: openstack-k8s-operators/ci-framework#4055
Related: OSPRH-32310
Assisted-By: Claude Code