Add edpm_cyborg role for Cyborg agent dataplane deployment - #1180
Add edpm_cyborg role for Cyborg agent dataplane deployment#1180amoralej wants to merge 1 commit into
Conversation
cafd94d to
887fe48
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 24m 09s |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 26m 15s |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 41m 44s |
|
check-rdo |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 7m 02s |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 23m 02s |
|
check-rdo |
|
edpm_cyborg role tested in https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/3eacd2d9dff449a284fa7e9ca75c14bc via depends-on in openstack-k8s-operators/nova-operator#1143 |
melwitt
left a comment
melwitt
left a comment
There was a problem hiding this comment.
Looks good to me, just a couple of small questions.
The testing with openstack-k8s-operators/nova-operator#1143 is really great, so thank you for that :)
|
|
||
| collections: | ||
| - ansible.posix | ||
| - community.crypto |
There was a problem hiding this comment.
Do you need this here as it's already included in collections.yml? IIUC these are global requirements and not sure it's needed other than the testing area.
| ansible.builtin.assert: | ||
| that: | ||
| - "cyborg_user.ansible_facts.getent_passwd.cyborg[1] == '42592'" | ||
| - "cyborg_user.ansible_facts.getent_passwd.cyborg[2] == '42592'" |
There was a problem hiding this comment.
This user ID 42592 is different than the user ID in the DNM testing patch (42483) [1], is that expected or should they be the same?
There was a problem hiding this comment.
I don't know where i took that from ... Yes, it should be the same.
Done!
2193429 to
ee28866
Compare
There was a problem hiding this comment.
Updates look good and passing the latest run [1] of the nova-operator-cyborg-tempest-multinode job [2][3] via the DNM PR, LGTM.
[1] openstack-k8s-operators/nova-operator#1143 (comment)
[2] https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/518255a7131c4e17a20c84a0ae4b221c
[3] https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/logs//563/rdoproject.org/563f8fcbe5a940ce9d986c3064310b11/controller/ci-framework-data/tests/test_operator/tempest-tests-tempest/tempest_results.html
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amoralej, melwitt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
amartyasinha
left a comment
amartyasinha
left a comment
There was a problem hiding this comment.
Overall lgtm! Haven't tested it personally.
| @@ -0,0 +1 @@ | |||
| --- | |||
There was a problem hiding this comment.
Even though post-install.yml is empty, but we've added it. I was wondering if there's some validation in edpm-ansible which requires this task file to be a part of roles?
|
New changes are detected. LGTM label has been removed. |
Deploy the cyborg-agent as a Podman container on EDPM compute nodes for accelerator lifecycle management (GPUs, FPGAs, etc.). The role discovers config files mounted by the dataplane operator, syncs them to the host, and runs the agent with device access. It uses quadlet to run the container as systemd service. Includes playbook, molecule tests, argument specs, documentation, and CI integration. Assisted-By: claude Signed-off-by: Alfredo Moralejo <amoralej@redhat.com>
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 38m 23s |
3 participants
Deploy the cyborg-agent as a Podman container on EDPM compute nodes for accelerator lifecycle management (GPUs, FPGAs, etc.). The role discovers config files mounted by the dataplane operator, syncs them to the host, and runs the agent with device access.
Includes playbook, molecule tests, argument specs, documentation, and CI integration.
Assisted-By: claude