-
Notifications
You must be signed in to change notification settings - Fork 85
OCPBUGS-121303,OCPBUGS-121304: Bump goreleaser to v2.18.0, go-git to v5.19.2 #2917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ankitathomas
wants to merge
1
commit into
operator-framework:main
Choose a base branch
from
ankitathomas:version-bump
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT | ||
|
|
||
| go 1.24.6 | ||
| go 1.25.0 | ||
|
|
||
| replace github.com/go-git/go-git/v5 => github.com/go-git/go-git/v5 v5.19.2 | ||
|
|
||
| require sigs.k8s.io/crdify v0.6.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT | ||
|
|
||
| go 1.24.6 | ||
| go 1.27.1 | ||
|
|
||
| require github.com/goreleaser/goreleaser/v2 v2.11.2 | ||
| require github.com/goreleaser/goreleaser/v2 v2.18.1 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
🔎 Supported by static analysis
🏁 Script executed:
Repository: operator-framework/operator-controller
Length of output: 339
🤖 get_repo_knowledge executed:
get_repo_knowledge operator-framework/operator-controller /tmp/coderabbit-repo-knowledge/operator-framework-operator-controller-ce4a649e/conventionsLength of output: 6833
🏁 Script executed:
Repository: operator-framework/operator-controller
Length of output: 10271
🏁 Script executed:
Repository: operator-framework/operator-controller
Length of output: 13249
🌐 Web query:
site:go.dev/doc/toolchain Go toolchain selection go.mod go directive GOTOOLCHAIN auto local -modfile💡 Result:
The Go toolchain selection mechanism allows the Go command to automatically manage and switch to the required toolchain version specified in a project's go.mod or go.work file [1]. At startup, the Go command determines which toolchain to execute by consulting the GOTOOLCHAIN environment variable and the directives found in the current environment's configuration [1]. GOTOOLCHAIN Settings: The GOTOOLCHAIN variable is composed of two parts: a default toolchain (e.g., local) and a selection strategy (+auto or +path) [1]. - local: Refers to the toolchain bundled with the Go command currently being run [1]. - auto: Shorthand for local+auto. If the project requires a newer version than the local toolchain, Go will attempt to automatically download and run the required version [1]. - path: Shorthand for local+path. If the project requires a newer version, it will look for the required version in the user's system PATH [1]. Selection Logic: When the strategy (such as +auto) is active, the Go command examines the following in order of precedence: 1. toolchain directive: If the go.mod or go.work file contains a toolchain line, the Go command will use that specific version if it is newer than the local toolchain [1]. 2. toolchain default: If the file contains toolchain default, the Go command will explicitly use the local toolchain, ignoring any newer requirements [1]. 3. go directive: If no toolchain directive is present, the Go command checks the go line. If the specified version is newer than the local toolchain, it will use the requested version instead [1]. In essence, GOTOOLCHAIN=auto allows developers to define the required Go environment within their module files, enabling the toolchain to self-update or switch versions dynamically to match project requirements without manual intervention [1].
Citations:
🏁 Script executed:
Repository: operator-framework/operator-controller
Length of output: 1466
Keep the Bingo module within the supported Go version.
.bingo/goreleaser.moddeclaresgo 1.27.1, while the repository root declaresgo 1.26.3.go-verdiffrejects this module and fails the workflow unless the override label is present. Regenerate the Bingo module with Go1.26.3, or update the repository Go version and CI policy together.🤖 Prompt for AI Agents
Source: Pipeline failures