🐛 Use ClusterObjectSet revision numbers in rollout status messages

[fao89]

Description

Use ClusterObjectSet.spec.revision in rollout status messages instead of the bundle version annotation. This identifies the revision being reconciled and keeps messages meaningful for standalone ClusterObjectSets that have no bundle version annotation. For example, revision 1 installing bundle version 1.0.2 now reports Revision 1 is rolling out.

Apply the numeric revision to rollout progress, availability, and completion messages. Update controller unit-test expectations and the two ClusterExtension E2E progress-deadline scenarios to match, including the last rollout status embedded in timeout messages.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

Summary by CodeRabbit

• Bug Fixes
  • Rollout, availability, and progress-deadline messages now identify ClusterObjectSet revisions by their numeric revision sequence, such as “Revision 1,” instead of displaying bundle versions.

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	fb4c307
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6abd84ce1b360e0008ff0ed0
😎 Deploy Preview	https://deploy-preview-2963--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4c4e84f1-6716-4352-a9a8-0529e10018cf

📥 Commits

Reviewing files that changed from the base of the PR and between aa82c0d and fb4c307.

📒 Files selected for processing (3)

• internal/object-controller/controllers/clusterobjectset_controller.go
• internal/object-controller/controllers/clusterobjectset_controller_test.go
• test/e2e/features/install.feature

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

ClusterObjectSet rollout, success, and incomplete-revision status messages now use the numeric spec.revision value instead of the bundle-version annotation. Unit and end-to-end test expectations reflect the revised messages.

Changes

Revision status messages

Layer / File(s)	Summary
Use numeric revisions in status messages internal/object-controller/controllers/clusterobjectset_controller.go, internal/object-controller/controllers/clusterobjectset_controller_test.go, test/e2e/features/install.feature	Status messages identify rolling out, successful, and incomplete revisions by numeric spec.revision. Unit and end-to-end expectations use the updated messages.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: perdasilva

Merge Risk: ⚪ Minimal · up to fb4c3

The revised rollout, completion, and deadline messages consistently identify the numeric revision, and the updated scenarios check the generated status text. No PR-specific issue blocks merging; tests were not executed in this review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: using ClusterObjectSet revision numbers in rollout status messages.
Description check	✅ Passed	The description explains the change, motivation, affected message types, and test updates. It includes the required Description and Reviewer Checklist sections.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[perdasilva]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[perdasilva]

/lgtm

very straightforward change lgtm'ing as well