Skip to content

net/freeradius: quote password values literally so % is not expanded #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dotCooCoo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

net/freeradius: quote password values literally so % is not expanded #5695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions net/freeradius/src/opnsense/service/templates/OPNsense/Freeradius/users
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{% for user_list in helpers.toList('OPNsense.freeradius.user.users.user') %}
{% if user_list.enabled == '1' %}

{{ user_list.username }} {{ user_list.passwordencryption }} := "{{ user_list.password }}"{% if helpers.exists('OPNsense.freeradius.general.sessionlimit') and OPNsense.freeradius.general.sessionlimit == '1' %}{% if user_list.sessionlimit_max_session_limit is defined %}, Max-Daily-Session := {{ user_list.sessionlimit_max_session_limit }}{% endif %}{% endif %}{% if user_list.simuse is defined %}, Simultaneous-Use := "{{ user_list.simuse }}"{% endif %}{% if user_list.logintime is defined %}, Login-Time := "{{ user_list.logintime }}"{% endif %}
{{ user_list.username }} {{ user_list.passwordencryption }} := '{{ user_list.password }}'{% if helpers.exists('OPNsense.freeradius.general.sessionlimit') and OPNsense.freeradius.general.sessionlimit == '1' %}{% if user_list.sessionlimit_max_session_limit is defined %}, Max-Daily-Session := {{ user_list.sessionlimit_max_session_limit }}{% endif %}{% endif %}{% if user_list.simuse is defined %}, Simultaneous-Use := "{{ user_list.simuse }}"{% endif %}{% if user_list.logintime is defined %}, Login-Time := "{{ user_list.logintime }}"{% endif %}

{% if user_list.ip is defined %}
Framed-IP-Address = {{ user_list.ip }},
Expand All @@ -25,7 +25,7 @@
{% endfor %}
{% endif %}
{% if user_list.tunnel_password is defined %}
Tunnel-Password = {{ user_list.tunnel_password }},
Tunnel-Password = '{{ user_list.tunnel_password }}',
{% endif %}
{% if helpers.exists('OPNsense.freeradius.general.vlanassign') and OPNsense.freeradius.general.vlanassign == '1' %}
{% if user_list.vlan is defined %}
Expand Down Expand Up @@ -121,7 +121,7 @@ DEFAULT Auth-Type := Accept
Tunnel-Private-Group-Id = {{ OPNsense.freeradius.general.fallbackvlan_id }},
{% endif %}
{% if helpers.exists('OPNsense.freeradius.general.fallback_tunnel_password') and OPNsense.freeradius.general.fallback_tunnel_password != '' %}
Tunnel-Password = {{ OPNsense.freeradius.general.fallback_tunnel_password }},
Tunnel-Password = '{{ OPNsense.freeradius.general.fallback_tunnel_password }}',
{% endif %}
Framed-Protocol = PPP
{% endif %}
Expand Down