Repository navigation
feat: show compilation errors in the Vite dev overlay - #806
Merged
samuelstroschein merged 2 commits intoOct 13, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32b54a8e9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start Vite with a valid Paraglide project, then replace
project.inlang/settings.jsonwith{. The compiler logs an error, but the browser keeps showing the last generated output without an overlay.The Vite plugin now shows compilation and config errors in the development overlay and sends pending diagnostics to new tabs and reconnecting clients. It retains errors raised before any browser connects, so older Vite versions cannot replay an obsolete buffered error. The listener survives restarts that reuse an inline plugin.
Input edits retry an invalid config before recompiling, so generated HMR does not dismiss the pending config error. Once compilation and config loading recover, the plugin requests a page reload. Recovering from an invalid config may not write any generated files, so no file update triggers HMR. The reload drops client state and can occur alongside Vite's own file updates. Requests continue to be served during a failure, and production error handling stays unchanged.
Based on
main. The source changes combine cleanly with #794 ate0cf6b9; the combined plugin and translation-check suites pass all 59 tests.Validation:
pnpm run cipassed with Node 22.23.3 and pnpm 10.23.0 on macOS. It built the package, all four framework packages, the nine workspace examples and the website. Tests passed: 621 in the package, 18 in frameworks, 12 in examples and 21 in the website; five package tests were skipped.mainatf0f4be8. All 32 plugin tests and the typecheck passed on that combination.mainwithout this patch. Oxlint exits successfully with four warnings also present onmain.The overlay regressions failed before the fixes. The WebSocket tests use Node 22+, matching CI. Ubuntu execution and browser rendering were not tested locally.