Make ParsedEnvelope and Envelope public#4249
Conversation
…dEnvelope::from_transaction
raphjaph
left a comment
raphjaph
left a comment
There was a problem hiding this comment.
LGTM, but please run cargo fmt --all to fix the linter error in CI. Normally I would just fix it but I can't push to your master branch.
raphjaph
left a comment
raphjaph
left a comment
There was a problem hiding this comment.
Can you please allow maintainers to make changes to this branch?
The branch needs to be updated with the latest changes from master.
|
I have sent you invite to the fork access. P.S. If I misunderstand what exactly was meant, please tell where to find the required Github feature to allow upstream maintainers access. |
|
Normally there should be a check box in the bottom right that allows maintainers to make changes to branches on PRs. It should usually be on by default. Maybe if you open the PR from a feature branch instead of 
|
2 participants
Fix #4246, the PR allows people to access ParsedEnvelope::from_transaction for parsing inscriptions from their Rust code.