Every source implementation (range, wordlist, timestamps, files, stdin) calls .ok() on output.hit() and output.key(), silently discarding I/O errors. If the output backend fails mid-run (disk full, broken pipe), processing continues and results are lost without any notification.
Spotted during #76 review but it's across all sources, not specific to wordlist streaming.
Options:
- Propagate errors with
? (requires reworking the Rayon closures since par_chunks/par_iter closures can't return Result)
- Collect errors with a shared
AtomicBool poison flag and bail after the chunk
- Log the first error and continue (lossy but at least visible)
The Rayon constraint is the main reason .ok() exists here in the first place.
Every source implementation (range, wordlist, timestamps, files, stdin) calls
.ok()onoutput.hit()andoutput.key(), silently discarding I/O errors. If the output backend fails mid-run (disk full, broken pipe), processing continues and results are lost without any notification.Spotted during #76 review but it's across all sources, not specific to wordlist streaming.
Options:
?(requires reworking the Rayon closures sincepar_chunks/par_iterclosures can't returnResult)AtomicBoolpoison flag and bail after the chunkThe Rayon constraint is the main reason
.ok()exists here in the first place.