Skip to content

OSAC-3617: UI chart - change default api url to internal - #148

Open
rawagner wants to merge 1 commit into
osac-project:mainfrom
rawagner:OSAC-3617
Open

OSAC-3617: UI chart - change default api url to internal#148
rawagner wants to merge 1 commit into
osac-project:mainfrom
rawagner:OSAC-3617

Conversation

@rawagner

@rawagner rawagner commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Updated the UI’s fulfillment service connection to use the correct internal endpoint.
    • This resolves connectivity issues and helps ensure fulfillment-related information loads reliably within the application.

@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2026

Copy link
Copy Markdown

@rawagner: This pull request references OSAC-3617 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rawagner
Once this PR has been reviewed and has the lgtm label, please assign adriengentil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 90cc4ec7-609b-4e0a-9c25-a464338e3470

📥 Commits

Reviewing files that changed from the base of the PR and between 0fec1ac and e63a138.

📒 Files selected for processing (1)
  • osac-installer/charts/osac/values.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • osac-installer/charts/osac/values.yaml

Walkthrough

The Helm values update the UI fulfillment API URL from https://fulfillment-api:8000 to https://fulfillment-internal-api:8001.

Changes

Fulfillment API routing

Layer / File(s) Summary
Update UI fulfillment endpoint
osac-installer/charts/osac/values.yaml
The UI fulfillment URL now targets https://fulfillment-internal-api:8001 instead of https://fulfillment-api:8000.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: larsks, vladikr

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ai-Attribution ⚠️ Warning The PR context mentions CodeRabbit, but commit e63a138 has no Assisted-by or Generated-by trailer and no valid AI attribution. Add an AI attribution trailer, such as Assisted-by: CodeRabbit <...> or Generated-by: ...; do not use Co-Authored-By for the AI tool.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change to the UI chart's default API URL.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The commit changes only the UI URL to https://fulfillment-internal-api:8001; it has no embedded credentials, secret literal, token, key, password, or private-key material.
No-Weak-Crypto ✅ Passed The commit changes only the UI API URL; the changed chart scope contains no MD5, SHA1, DES, RC4, Blowfish, ECB, or custom crypto usage.
No-Injection-Vectors ✅ Passed The only change is a static HTTPS URL in Helm values.yaml; it adds no SQL, shell, eval/exec, pickle, unsafe YAML loading, os.system, or HTML injection vector.
Container-Privileges ✅ Passed The PR changes only the UI fulfillment URL. Affected chart templates set allowPrivilegeEscalation false and drop ALL capabilities, with no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or r...
No-Sensitive-Data-In-Logs ✅ Passed The PR changes one Helm URL value only; searches found no new logging statement or secret, token, PII, or customer data emitted by this change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants