Skip to content

OSAC-3954: fix stale comment — reference resolution now sets Id and Name #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omer-vishlitzky merged 1 commit into from
Aug 12, 2026
Merged

OSAC-3954: fix stale comment — reference resolution now sets Id and Name #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions fulfillment-service/internal/servers/private_clusters_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,8 +596,7 @@ func (s *PrivateClustersServer) validateTemplateImmutability(ctx context.Context
}

// Check if template has changed. Compare by refKey (Id) rather than proto.Equal because
// validateAndTransformCluster normalizes the stored reference to Id-only, while the
// reference validator interceptor may backfill Name on incoming requests.
// the reference validator interceptor may backfill additional fields on incoming requests.
if updatingTemplate && refKey(existingSpec.GetTemplate()) != refKey(newSpec.GetTemplate()) {
return grpcstatus.Errorf(
grpccodes.InvalidArgument,
Expand Down
Loading