Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Replace cli-cursor with a tiny ANSI-escape helper, reuse the existing lib/cli/parse-args for argv parsing, and replace traverse with a small leaf walker. Removes 71 transitive packages. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Delete lib/compose/utils/serverless-utils/, which was a copy of the parent project's lib/utils/serverless-utils/ carried over from the old standalone @osls/compose project. Route compose's logging init through the parent's existing log-reporters/node module (same pattern as scripts/serverless.js). Drop uni-global, only used by the duplicate. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Delete lib/compose/utils/fs/, which duplicated the parent project's lib/utils/fs/ helpers (fileExists, readFile, writeFile, parseFile, isJsonPath/isYamlPath). The compose-only extras (slsignore parsing, optional YAML options, extra prototype-pollution guards) were not exercised by any compose source path — only by the duplicate's own tests. Re-route the three real callers (configuration/resolve-path, ComponentsService, state/LocalStateStorage) to the parent helpers.
Delete lib/compose/serverless-error.js — its only behavioral difference vs the parent's lib/serverless-error.js was an unused "previous" arg that appended a wrapped error's stack. No compose caller passed a 3rd arg, so the feature was dead. Re-route all 15 source requires and 1 test require to the parent class.
Delete 9 lib/compose/utils/ files that duplicated lib/utils/ helpers (6 byte-identical, 3 functionally equivalent: validate-stage, tokenize-exception, sleep). Reroute the few compose source consumers of colors, spawn, validate-stage, tokenize-exception, and sleep to the parent's modules. Also drop the 6 corresponding compose tests since the parent already covers each utility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge https://github.com/oss-serverless/compose in the main project to avoid maintaining 2 codebases.
The functionality should be unchanged for users.