3rdparty: point libossia and avendish at their master commits - #2178
Merged
Conversation
#2163 landed with these pinned to the branches it was developed against, which was right while those branches were what carried the changes. They have since been merged, and rebased in the merging, so the commits master records here do not exist on libossia master or avendish main - they exist only on fix/backwards-playback-dataflow and fix/quantification-backwards. That resolves today, because those branches are still there. It stops resolving the moment either is deleted, and a fresh clone of score can no longer check out its submodules. Point them at the same work as it landed upstream: libossia b167d39b7 -> cdeb2619e build: version Boost.Asio's global symbols avendish 948d21d25 -> cb3d29191 halp: one quantification grid, walked once The source is identical either way - the only difference between the branch tips and these is .github/workflows, which upstream changed while the branches were open, so this also stops score pinning both projects to their pre-merge CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2163 landed with the submodules pinned to the branches it was developed against. Those have since been merged, and rebased in the merging, so the commits master records don't exist on
libossia/masteroravendish/main— they exist only on the source branches.It resolves today only because those branches still exist. Delete either and a fresh clone of score can no longer check out its submodules.
The change
Both verified reachable from
libossia/masterandavendish/mainrespectively.Same source
I checked rather than assumed — the trees are not byte-identical, but the entire difference is
.github/workflows/*, which upstream changed while the branches were open:So no source change, and score stops pinning both projects to their pre-merge CI as a side benefit.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGta2LPAedDP3Txvyq8kTW