Fix FFmpeg video decoder packet and frame draining - #2195
Draft
darioriccio wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 10, 2026
Member
|
hello ! can you check if this works fine on top of #2121 ? as it's a pretty big refactor of all the video part to enable better performance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
avcodec_send_packetreports decoder back-pressureRoot cause
The previous loop consumed the next demuxed packet after
avcodec_send_packetreturnedEAGAIN, even though FFmpeg requires the caller to receive pending frames and retry the unchanged packet. Inter-frame HEVC streams then lost reference packets and repeatedly emittedCould not find ref with POC, eventually freezing.Verification
VideoDecoderpath and hardware decoding disabled: an 8K HEVC video advanced continuously, produced distinct rendered frames, and emitted no HEVC POC/reference errorsThis is intentionally limited to the background decoder send/receive contract; it does not change renderer selection or UI behavior.