Accept enumerated device settings in the QML API - #2197
Draft
darioriccio wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QVariantoverload forEditJsContext::createDeviceQJSValueoverload for JavaScript object literalsDevice::DeviceSettingsvalues returned byenumerateDevices()to be passed back tocreateDevice()Without this overload, current Qt rejects the enumerated native value before the existing
canConvert<Device::DeviceSettings>()path can run. This is reproducible with Domeport Pro selecting a Syphon source.Verification
The clean macOS integration artifact built successfully in DomeportPro run 31439148108. Runtime selection of
VR Converter Live Outputthen loggedCreated Syphon input, rendered moving Metal frames in both equirectangular and domemaster modes, and no longer emitted the QVariant-to-QJSValue conversion error.