gig: try the GIG branch of deuterium - #2202
Open
jcelerier wants to merge 2 commits into
Open
Conversation
PR2202 was pushed before the deuterium feature/gig branch existed, yet most
jobs went green: src/addons/CMakeLists.txt only globs the directories that are
there, so a missing or stale add-on is not a build error.
Four separate holes let it through:
- osx.brew.deps.sh dropped errexit for the whole file, and bash 3.2 on macOS
sees "${empty[@]}" as unbound under -u, so the deuterium clone died and the
build silently configured 16 add-ons instead of 17
- win32{,.msvc}.deps.sh had no errexit at all and built deuterium at master
- bsd.yml ran common.deps.sh directly, which had no errexit of its own, and
used `cmd && echo Success` so a failing deps step still ran the build
- the platform argument defaulted instead of being validated
common.deps.sh is now strict on its own, checks its exit status for callers
that are not, and verifies at the end that every requested add-on is present
and on the requested ref. Refs go through an explicit fetch (fails on an
unknown ref, handles branches/tags/sha1s) and re-sync their submodules, which
the previous checkout did not.
Also fixes the double `cd $folder` that prevented ref checkouts from applying
to pre-existing checkouts on self-hosted runners, and `git submodule update
-j16`, which git rejects.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.