Repository navigation
Preserve binary downloads and verify cross-language client parity - #275
Merged
Merged
Conversation
Emit response-specific binary metadata, including scalar aliases, and correct multiple-media tuple formatting. Add compiler-backed frontend coverage and document the coordinated Python runtime release requirement.
Pin compiler fixtures to the published runtime tag, require 2.0.0b11, and document the satisfied runtime dependency and remaining generator rollout.
kdubb
marked this pull request as ready for review
October 16, 2026 00:34
 [Medium impact] The PR appears safe to merge; no new blocking issues were found. SummaryPython and TypeScript clients now mark whole-body binary responses so downloads retain their bytes instead of being decoded as JSON or text.
Reviews (2) 路 Last reviewed commit: "Pin published Sunday TypeScript beta.12 ..." 路 Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Follow named and inline union alternatives through scalar aliases, marking a response binary only when every branch is binary. Cover all-binary and nested unions plus mixed-union media decoding with compiled generated clients.
Emit binary response metadata for binary schemas, aliases, and nested all-binary unions. Compile and execute OpenAPI and RAML download clients for Kotlin, Swift, and TypeScript, including mixed unions and explicit empty-body contracts. Update the compiled snapshot and document the coordinated TypeScript runtime release dependency.
kdubb
changed the title
kdubb
marked this pull request as draft
October 16, 2026 01:20
Update compiler fixture dependency and integrity-checked lockfile to the released runtime. Document satisfied coordinated runtime dependencies and verify 183 generator tests against published packages without local runtime overrides.
kdubb
marked this pull request as ready for review
October 16, 2026 01:39
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Python and TypeScript binary downloads must preserve response bytes even when the server advertises JSON or text. Emit explicit binary-response metadata for whole-body binary schemas, named aliases, and unions whose branches are all binary. Mixed unions and structured binary fields retain media decoding. Also correct Python multi-media tuple formatting.
Addresses outfoxx/sunday-python#12.
Coordinated runtime dependencies
2.0.0-beta.11Git tag. Verified2.0.0b11wheel/source artifacts are available from its release workflow; PyPI publication remains disabled.@outfoxx/sunday@2.0.0-beta.12. The tag targets merge commite5bf92cb9b34057116cb266cbf5088969a4e0b59. This PR pins that version and the registry tarball integrity in the compiler-fixture lockfile. The release workflow succeeded and npm'sbetatag points to beta.12.Both runtime release dependencies are satisfied. The remaining rollout is to merge/release the generator and regenerate consuming clients. Runtime updates alone cannot add binary metadata to older generated clients. Keep issue #12 open until generator rollout and consumer verification complete.
Validation
SUNDAY_TYPESCRIPT_PATH,SUNDAY_PYTHON_PATH, andSUNDAY_SWIFT_PATHunset and a fresh npm cache.image/pngAccept negotiation and exact-byte preservation of a JSON-typed download through both runtime result APIs.Hosted checks for the latest PR head are separate from the local verification above.