fix(rules): classify semantic stem parse refusals as schema-valid - #212
Merged
Conversation
Use typed ParseStem errors to carry stem-health metadata (check, field, reason) without string parsing in EvaluateStemState. YAML syntax errors remain yaml-valid, while unsupported stem versions and null schema field refusals now surface as schema-valid with field metadata and path-free stem_health messages. Docs and validate references now list schema-valid as a public stem-health category. Closes #199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Classify semantic
.stemparse refusals asschema-validwhile preservingyaml-validfor YAML syntax failures. Populate field metadata and remove absolute filesystem paths from publicstem_healthmessages.Related issue
Closes #199
Why
ParseStempreviously returned undifferentiated text errors, so stem health mislabeled semantic schema refusals as YAML failures, omitted the affected field, and exposed absolute local or CI paths.How
errors.Asin stem health without parsing strings.schema-validcategory and record the contract in ADR 0004.Checklist
go test ./... -race)go vet ./...viajust check/golangci-lint and build gates)