fix(skill): verify staged symlink identity - #216
Merged
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
rootline skill installwhen the Agents/Pi preimage is a symlink to the Claude destination being replaced by the same approved plan.Related issue
Refs #210
The issue remains open until the real-home migration is retried with a complete receipt and runtime discovery is verified.
Why
The first post-merge operational run exposed a false
staged preimage evidence changedfailure. Install replaced Claude first; the existing Agents symlink still had the exact same lexical target, but its dereferenced digest changed because Claude now resolved to the canonical source. The operation incorrectly treated its own prior action as external preimage drift.The failed operation remained fail-closed and preserved an incomplete receipt plus verified backup evidence.
How
Verification
TestInstallConvergesWhenAgentsPreimageTargetsClaudeDestinationfailed withstaged preimage evidence changedbefore the fix.go test ./internal/skilldist -race -count=1just testjust checkjust coverage-check— total 89.9%,internal/skilldist85.4%Checklist
go test ./... -race)go vet ./...via project checks)Refs #210; closure waits for the completed operational gate