fix(rules): honor descendant scope matches - #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scope-matchrecognize matching files in descendant directories governed by an ancestor.stemscope.matchoverrides and nestedroot: truestemsRelated issue
Closes #214
Why
validate --allrecursively discovered and validated descendantCONTRACT.mdrecords, while stem health inspected only files beside the declaring.stem. Under--strict, that mismatch produced exit 1 for an otherwise valid corpus.How
StemState.EffectiveScopeMatchesderives the closest non-emptyscope.matchowner from each inventoried file's existing governanceChain.EvaluateStemStateconsumes that state-local presence map, keeping prospective overlay evaluation pure and avoiding a second filesystem/resolution authority.Regression coverage includes inherited descendant matches, child overrides, nested roots, direct matches, true orphan scopes, and the exact two-descendant
validate --all --strictacceptance case.Verification
just checkjust testjust coverage-check— 89.9% total; every package floor passedjust validate— 126/126 roadmap records valid85e84a5..21a4fd5— READY, no Critical/Important findingsChecklist
go test ./... -race)go vet ./...)