You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the Infrastructure Review workflow to run Terraform-related Nx tasks with --outputStyle=stream-without-prefixes.
In our CI context, Nx grouped/static output was causing Terraform plan logs to appear truncated for large environments.
With this change:
full Terraform plan output is preserved in step logs;
noisy per-line project prefixes are removed;
no custom plan truncation or GitHub Step Summary fallback is needed in the dx-tasks plugin.
Does the summary have any similar limit? Perhaps it can be solved by disabling NX groups? I sincerely don't know
@krusty93 What do you mean by summary limit? This PR addresses the issue where the terraform plan done in validate_v2.yaml was being truncated in the step logs. This happens because each step has a maximum limit of 65k characters, and large plans were exceeding this threshold. For example this is an execution without the PR fix.
I mean the summary where this PR is moving the output, perhaps it does have a similar limit as the PR comments?
About the example run you linked, it seems very short to hit a limit. We saw several times runs with bigger outputs there were not truncated. For example, this one is way longer than the example (227k characters vs 65k). Something is hinting the limit is imposed by the NX sub-groups instead
I mean the summary where this PR is moving the output, perhaps it does have a similar limit as the PR comments?
About the example run you linked, it seems very short to hit a limit. We saw several times runs with bigger outputs there were not truncated. For example, this one is way longer than the example (227k characters vs 65k). Something is hinting the limit is imposed by the NX sub-groups instead
@krusty93 Great point, thanks!
In this commit 87bea3f I've removed the GITHUB_STEP_SUMMARY workaround and the 50k truncation logic from the Terraform task, so we now emit the full plan output again.
I also switched nx affected to --outputStyle=stream in validate-v2.yaml to bypass Nx grouped/static output handling in CI, which looks like the likely source of the truncation behavior we were seeing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Infrastructure Review workflow to run Terraform-related Nx tasks with
--outputStyle=stream-without-prefixes.In our CI context, Nx grouped/static output was causing Terraform plan logs to appear truncated for large environments.
With this change:
Resolves: CES-2197