Skip to content

feat(IT-Wallet): [SIW-3963] Request status list during credentials issuance#8261

Open
gispada wants to merge 36 commits into
masterfrom
SIW-3963-credential-tsl
Open

feat(IT-Wallet): [SIW-3963] Request status list during credentials issuance#8261
gispada wants to merge 36 commits into
masterfrom
SIW-3963-credential-tsl

Conversation

@gispada

@gispada gispada commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Short description

This PR requests the status list at the end of the issuance flow for the new 1.3 credentials, while older credentials still request the status assertion.
To have the two validity mechanisms coexist, the storedStatusAssertion property in the credential metadata bundle has been renamed to validity.

Note

Note 1 Migration for existing 1.3 credentials has been skipped because it requires async logic and the complexity is not worth it for the pre environment and a small group of users: these users will need re-obtain their credentials to get the status list.
Note 2 Dynamic errors from the status list code are not included in this PR: they will be handled in SIW-4682.

List of changes proposed in this pull request

  • Renamed storedStatusAssertion to validity
  • Modified the obtainStatusAssertion machine actor to request either the status list or assertion depending on the active IT-Wallet version
  • Fetched the status list and extracted the status at the end of the upgrade flow
  • Updated several tests

How to test

Migration

  1. Get Documenti su IO and a few credentials on the master branch
  2. Switch to this branch and ensure the migration has worked by checking the global store at features.itWallet.credentials.credentials[<id>].validity

Upgrade

With Documenti su IO and a few credentials, upgrade to IT-Wallet and ensure the validity property is set with the status (for instance "VALID") and the status list reference.

New issuance

Get a new IT-Wallet credential and ensure the validity property is set with the status (for instance "VALID") and the status list reference.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@gispada gispada self-assigned this Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 39.77273% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.07%. Comparing base (b548ddd) to head (50edb9f).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../ts/features/itwallet/machine/credential/actors.ts 16.66% 15 Missing ⚠️
...app/ts/features/itwallet/machine/upgrade/actors.ts 9.09% 10 Missing ⚠️
...app/ts/features/itwallet/statusList/utils/index.ts 10.00% 9 Missing ⚠️
...tures/itwallet/statusList/store/selectors/index.ts 0.00% 4 Missing ⚠️
...s/features/itwallet/statusList/utils/repository.ts 33.33% 3 Missing and 1 partial ⚠️
.../common/utils/itwCredentialStatusAssertionUtils.ts 57.14% 1 Missing and 2 partials ⚠️
...ails/hooks/useItwStartCredentialSupportRequest.tsx 57.14% 1 Missing and 2 partials ⚠️
.../itwallet/common/utils/itwCredentialStatusUtils.ts 66.66% 2 Missing ⚠️
...redentials/saga/checkCredentialsStatusAssertion.ts 0.00% 2 Missing ⚠️
...pp/ts/features/itwallet/statusList/utils/errors.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8261      +/-   ##
==========================================
- Coverage   63.09%   63.07%   -0.03%     
==========================================
  Files        1959     1961       +2     
  Lines       37136    37223      +87     
  Branches     6244     6264      +20     
==========================================
+ Hits        23432    23478      +46     
- Misses      12329    12371      +42     
+ Partials     1375     1374       -1     
Files with missing lines Coverage Δ
...ts/features/itwallet/common/utils/itwTypesUtils.ts 25.00% <ø> (ø)
...ntials/saga/handleItwCredentialsStoreBundleSaga.ts 92.85% <100.00%> (+1.94%) ⬆️
.../itwallet/credentials/store/reducers/migrations.ts 96.55% <100.00%> (+0.32%) ⬆️
...ts/features/itwallet/machine/credential/failure.ts 25.00% <ø> (ø)
...ts/features/itwallet/machine/credential/machine.ts 95.83% <ø> (ø)
...ponents/ItwPresentationCredentialUnknownStatus.tsx 88.88% <100.00%> (-0.40%) ⬇️
...tures/itwallet/presentation/details/utils/index.ts 78.94% <ø> (ø)
...pp/ts/features/itwallet/statusList/utils/errors.ts 0.00% <0.00%> (ø)
.../itwallet/common/utils/itwCredentialStatusUtils.ts 81.25% <66.66%> (ø)
...redentials/saga/checkCredentialsStatusAssertion.ts 2.50% <0.00%> (ø)
... and 7 more

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6b1b7...50edb9f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gispada
gispada marked this pull request as ready for review July 21, 2026 09:21
@gispada
gispada requested review from a team, Leerti, emilio-dimari and soixdev91 as code owners July 21, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant