chore(IT-Wallet): [SIW-4688] Remove i18n dynamic keys from itwallet feature#8323
Merged
Conversation
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
mastro993
marked this pull request as ready for review
July 17, 2026 15:23
mastro993
requested review from
a team,
Leerti,
emilio-dimari,
gispada and
soixdev91
as code owners
July 17, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This pull request refactors how translation keys are selected throughout the itwallet feature, replacing dynamic string interpolation with explicit, conditional key selection.
List of changes proposed in this pull request
Translation Key Handling Improvements:
ItwCredentialClaim.tsxanditwClaimsUtils.ts, ensuring only valid keys are used. [1] [2]ItwEidLifecycleAlert.tsxto use the explicitisItwCredentialflag for translation key selection, removing thenameSpacevariable and improving clarity. [1] [2] [3] [4]Identification Flow and UI Consistency:
useContinueWithBottomSheet.tsxby usinguseMemoto select the correct copy for each identification type, removing dynamic key construction. [1] [2] [3]Credential Metadata Display:
ItwIssuanceMetadata.tsxto use a boolean flag for PID credential type and select the correct translation key for the "released by" label, improving readability. [1] [2]How to test
Navigate across impacted IT-Wallet features and verify that copy is correctly displayed