Skip to content

chore(IT-Wallet): [SIW-4688] Remove i18n dynamic keys from itwallet feature#8323

Merged
mastro993 merged 5 commits into
masterfrom
SIW-4688-remove-I18n-dynamic-keys
Jul 21, 2026
Merged

chore(IT-Wallet): [SIW-4688] Remove i18n dynamic keys from itwallet feature#8323
mastro993 merged 5 commits into
masterfrom
SIW-4688-remove-I18n-dynamic-keys

Conversation

@mastro993

@mastro993 mastro993 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Short description

This pull request refactors how translation keys are selected throughout the itwallet feature, replacing dynamic string interpolation with explicit, conditional key selection.

List of changes proposed in this pull request

Translation Key Handling Improvements:

  • Replaced dynamic translation key construction (e.g., using template strings or variable interpolation) with explicit conditional selection for boolean claims in ItwCredentialClaim.tsx and itwClaimsUtils.ts, ensuring only valid keys are used. [1] [2]
  • Updated eID lifecycle alert logic in ItwEidLifecycleAlert.tsx to use the explicit isItwCredential flag for translation key selection, removing the nameSpace variable and improving clarity. [1] [2] [3] [4]

Identification Flow and UI Consistency:

  • Refactored the CIE card reading progress and warning screens to select translation keys based on explicit platform/type/requirement checks, rather than interpolated strings, ensuring correct copy is always shown. [1] [2] [3] [4] [5] [6]
  • Improved the bottom sheet modal in useContinueWithBottomSheet.tsx by using useMemo to select the correct copy for each identification type, removing dynamic key construction. [1] [2] [3]
  • Updated the identification mode selection screen to use explicit key selection for section, title, and description based on flow and reissuance mode. [1] [2]

Credential Metadata Display:

  • Refactored ItwIssuanceMetadata.tsx to use a boolean flag for PID credential type and select the correct translation key for the "released by" label, improving readability. [1] [2]

How to test

Navigate across impacted IT-Wallet features and verify that copy is correctly displayed

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 51.51515% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.06%. Comparing base (d4bb585) to head (0a358fe).

Files with missing lines Patch % Lines
.../cie/screens/ItwIdentificationCieWarningScreen.tsx 0.00% 14 Missing ⚠️
...n/cie/components/ItwCieCardReadProgressContent.tsx 0.00% 4 Missing ⚠️
...omponents/ItwPresentationCredentialStatusAlert.tsx 50.00% 2 Missing and 2 partials ⚠️
...itwallet/common/components/ItwIssuanceMetadata.tsx 0.00% 0 Missing and 2 partials ⚠️
.../ts/features/itwallet/trustmark/machine/actions.ts 0.00% 2 Missing ⚠️
.../itwallet/common/components/ItwCredentialClaim.tsx 0.00% 1 Missing ⚠️
...twallet/common/components/ItwEidLifecycleAlert.tsx 85.71% 0 Missing and 1 partial ⚠️
...s/features/itwallet/common/utils/itwClaimsUtils.ts 0.00% 1 Missing ⚠️
...ntification/spid/screens/ItwSpidIdpLoginScreen.tsx 0.00% 1 Missing ⚠️
...onents/ItwPresentationCredentialCardFlipButton.tsx 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8323      +/-   ##
==========================================
- Coverage   63.06%   63.06%   -0.01%     
==========================================
  Files        1959     1959              
  Lines       37114    37151      +37     
  Branches     6240     6256      +16     
==========================================
+ Hits        23406    23429      +23     
- Misses      12333    12346      +13     
- Partials     1375     1376       +1     
Files with missing lines Coverage Δ
...cation/common/hooks/useContinueWithBottomSheet.tsx 66.66% <100.00%> (+7.57%) ⬆️
...n/screens/ItwIdentificationModeSelectionScreen.tsx 82.35% <100.00%> (ø)
...ents/ItwPresentationNewCredentialValidityAlert.tsx 100.00% <100.00%> (ø)
...ty/components/ItwProximitySendLoadingComponent.tsx 100.00% <100.00%> (ø)
...es/itwallet/settings/screens/ItwSettingsScreen.tsx 96.00% <100.00%> (ø)
...res/wallet/components/WalletCategoryFilterTabs.tsx 83.33% <100.00%> (+0.98%) ⬆️
.../itwallet/common/components/ItwCredentialClaim.tsx 46.80% <0.00%> (-0.51%) ⬇️
...twallet/common/components/ItwEidLifecycleAlert.tsx 80.64% <85.71%> (+2.86%) ⬆️
...s/features/itwallet/common/utils/itwClaimsUtils.ts 75.71% <0.00%> (-0.55%) ⬇️
...ntification/spid/screens/ItwSpidIdpLoginScreen.tsx 8.10% <0.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4bb585...0a358fe. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gispada gispada left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993
mastro993 added this pull request to the merge queue Jul 21, 2026
Merged via the queue into master with commit 5e2a679 Jul 21, 2026
12 checks passed
@mastro993
mastro993 deleted the SIW-4688-remove-I18n-dynamic-keys branch July 21, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants