Conversation
Pmat-Ticket: PMAT-1009
…ax-seq-len to 512 Pmat-Ticket: PMAT-1009
…e 512 literal at finetune.rs:717 is gone); one effective_max_seq_len() for every path, printed as Max seq len (PMAT-1009, #2924) Pmat-Ticket: PMAT-1009
…ve max_seq_len equals the request or the command refuses with the documented code; README contract count 1812 (PMAT-1009, #2924) Pmat-Ticket: PMAT-1009
…e rows Pmat-Ticket: PMAT-1009
noahgift
enabled auto-merge
September 6, 2026 05:47
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PP-066 DAG row T-2 (spec §5 "
--max-seq-lenhonoured or refused, never clamped"; S0-11; #2526; epic #2873; ticket PMAT-1009; receiptdocs/audits/impl-PMAT-1009-receipt.md,status: partialuntil merged).The defect:
apr finetune --gpu-backend wgpu --max-seq-len 1024silently trained at 512 — the wgpu instruct pipeline hardcoded512, // max_seq_len(finetune.rs:717) and dropped the CLI value; the instruct path honoured it since #2247, so a training receipt could record a configuration the engine never ran (T-0's apr arm cannot be paired until every path is honest).What lands: one
effective_max_seq_len(requested, path) -> Result<usize>forSeqLenPath::{Instruct, Wgpu, Classify}—Some(n)isOk(n)orValidationFailed(exit 5, read fromerror.rs),Noneis the path's default; the 512 literal is gone; every path printsMax seq len: <effective>. Case tablefinetune_seq_len_truth_tests.rs(RED first at 64e3d03: the function did not exist): {256, 512, 1024, 2048} × three paths, the default row, the refusal-code row. Contractcontracts/apr-finetune-config-truth-v1.yaml(kind: pattern); README 1812 contracts.Acceptance, re-run by the orchestrator on 2beca0d
cargo test -p apr-cli --lib finetune_seq_len_truthcargo test -p apr-cli --lib finetune(80 tests)cargo fmt --all -- --check·cargo clippy -p apr-cli --lib -- -D warningspv validate·pv lint·check_contract_test_binding.sh·check_contract_enforcement.sh·check_readme_claims.sh·check_no_claim_literals.sh·check_roadmap_diff_additive.shMutation — RED, then restored GREEN: the Wgpu branch returns
Ok(512)regardless of the request →effective_max_seq_len_wgpu_never_clamps_to_the_old_512_literalFAILED,effective_max_seq_len_honours_every_requested_value_on_every_pathFAILED (2/4) → restored 4/4.Recorded: the card's
--test finetune_seq_len_truthintegration target became a#[cfg(test)]module ofcommands::finetune(an integration test cannot reach the crate-privatecommandstree; thelib.rsseam is blocked by the pre-commit complexity gate on pre-existing debt — same finding as R-3); the test drives the pure function, an end-to-end wgpu run is T-0's harness. Receipt for this PR itself: advisory, not produced (driver A1).