Repository navigation
Conversation
…under its own name (#4189) binary-release.yml shipped apr and pv only; 27 workspace bins were built by the nightly and never attached to a tag. New `build-all-bins` lane (x86_64 on yoga, aarch64 on gx10, gnu in rust:1.93.0-bullseye): the bin set and the cargo selection are `nightly_manifest.py bins` of the tag tree, verbatim, never a hand list. apr/pv keep their dedicated lanes (a second pv-<tag>-<target> would clobber the pv asset). Before upload every bin must pass asset_version_check.sh under its own name, --help, the 2.31 glibc floor and `nightly_manifest.py smoke`; after upload every asset is read back. asset_version_check.sh accepted only `apr X.Y.Z (<sha>)`, so 28 of 29 real rc.1 lines were refused. It now takes an optional BIN (default apr, 3-arg callers unchanged), compares the name as a literal prefix, and accepts pv/pv-sat's trailing ` (<description>)`. Measured on the 29 --version lines of a stamped v0.70.0-rc.1 build at 9f56095: 29/29 ok once aprender-cgp prints its own [[bin]] name (clap name was "cgp"). 12 new case rows; two mutants (ignore the bin name; greedy sha field) each turn the table red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false) {
"ticket": "GH-4189",
"head": "ae34ee7cdd685e1c5abcf324ffc61cd7fd7c0362",
"width": 3,
"executor": "agy",
"agreed": false,
"auto_merge": {
"checked": true,
"was_armed": false,
"disarmed": false,
"note": "auto-merge not armed"
},
"lanes": [
{
"lane": 1,
"verdict": "FAIL",
"findings": 2
},
{
"lane": 2,
"verdict": "PASS",
"findings": 11
},
{
"lane": 3,
"verdict": "PASS",
"findings": 0
}
]
} |
… the nightly half is on base Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
quorum-review (AD-04): three PASS — agreed (auto_merge: checked=true was_armed=false disarmed=false) {
"ticket": "GH-4189",
"head": "e97655a8686d17d09216ad82b7326548b110c897",
"width": 3,
"executor": "agy",
"agreed": true,
"auto_merge": {
"checked": true,
"was_armed": false,
"disarmed": false,
"note": "auto-merge not armed"
},
"lanes": [
{
"lane": 1,
"verdict": "PASS",
"findings": 0
},
{
"lane": 2,
"verdict": "PASS",
"findings": 9
},
{
"lane": 3,
"verdict": "PASS",
"findings": 0
}
]
} |
…t-5, DEGRADED: cuda/mutation/agy unreachable) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4189 (G5). Stacked on
batch/ont-10(#4502); I'll retarget it tomainonce #4502 merges, per the cop's call. rc.1 is tagged after this merges.Problem. binary-release.yml attached
aprandpvonly. 27 of the 29 workspace[[bin]]s never reached a tag.asset_version_check.shalso refused every line exceptapr X.Y.Z (<sha>), so 28 of 29 real rc.1 lines failed.Change
build-all-binslane: x86_64 on yoga, aarch64 on gx10, gnu target, built inrust:1.93.0-bullseye.scripts/nightly_manifest.py binsrun on the tag tree, exactly as nightly.yml does it. There is no second list.aprandpvstay on their dedicated lanes. A secondpv-<tag>-<target>from this lane would clobber the pv asset.asset_version_check.sh TAG SHA LINE <bin>,--help, the GLIBC_2.31 floor, andnightly_manifest.py smoke.<bin>-<tag>-<target>.tar.gz+.sha256, sopromote_rc.shrenames them like the other assets.asset_version_check.sh:(<description>)that pv and pv-sat print after the sha.aprender-cgpnow prints its[[bin]]name; its clap name wascgp.Evidence
--versionlines of a stampedv0.70.0-rc.1build at 9f56095: 29/29 ok.--self-testPASS.cargo test -p aprender-cgp --lib --test integration: 121 + 29 passed.cargo fmtclean; actionlint shows only pre-existing info-level notes.Known gap.
check_release_assets.sh, theassetsskip gate, still lists the 18 apr/pv assets. A release that has those 18 but is missing only all-bins assets would skip this lane. A follow-up can derive the list.🤖 Generated with Claude Code