Repository navigation
fix(ci): check_ci_draft_skip.sh self-test exits 128 in clean-room (dubious ownership) — cancels every MG run - #6480
Conversation
…, not a repo query (Refs #6479) The --self-test exited 128 (dubious ownership) in the clean-room container where /workspace is owned by another uid, failing workspace-test-shard (3,4) on merge-group runs 40514962131 and 40523513222. The root is now taken from the script's own path, so no repo query runs. PMAT-Ticket: PMAT-6479 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
noahgift
left a comment
noahgift
left a comment
There was a problem hiding this comment.
seat 1 (non-author, claude-opus-5-5): APPROVE @1a72714b. --self-test green + 7/7 mutants red from root, abs path and other cwd; ci.yml mutation -> rc=1 (not vacuous); no remaining git calls; cd failure -> rc=1. Nit: CDPATH can corrupt root but fails closed.
noahgift
left a comment
noahgift
left a comment
There was a problem hiding this comment.
seat 2 (non-author, claude-haiku-5-5): APPROVE @1a72714b. Root resolves from script path regardless of cwd; no other git calls; self-test green, 7 mutants red; guard-removed workflow -> FAIL rc=1.
noahgift
left a comment
noahgift
left a comment
There was a problem hiding this comment.
sign-off (non-author, claude-opus-5-5): SIGN @1a72714b. Quorum AGREED 3/3 at head (author sonnet; lanes opus/haiku/argon), 2 non-author seats APPROVE at head, base main, same inputs give the same verdicts, CI green.
Closes #6479
scripts/check_ci_draft_skip.shrangit rev-parse --show-toplevelunconditionally, including under--self-test. In the clean-room merge-group container/workspaceis owned by another uid, git refuses it ("detected dubious ownership"), the script exits 128, and ci.yml's fail-fast step cancels the whole merge-group run.Evidence: MG runs 40514962131 (job 122226783260, 14:28:18Z) and 40523513222 (job 122257141354, log l.3959/3964 at 15:26:30Z):
FAIL [32/33] exit 128: bash scripts/check_ci_draft_skip.sh --self-test, thengh run cancel. This deterministically blocks every queued PR, including #6438.Fix: derive the repo root from the script's own path. An explicit workflow path argument is still honoured, and no check is skipped.
Verified: in an
ubuntu:22.04container running asnobody, on a repo owned by root, the old script gives rc=128 with the dubious-ownership error. The new script gives rc=0 with every self-test mutant red as expected.bashrs lintreports 0 errors andcargo fmt --all -- --checkis clean.Not covered: the other 32 Sections scripts were not audited for the same pattern.
🤖 Generated with Claude Code