Conversation
) The user resource's check was `id <name>`: a user with the wrong uid, shell, home, primary group or supplementary groups read as converged, so a changed declaration (e.g. dropping a group) never re-ran. The check now asserts each declared field against the live account via forjar's verdict module; the undeclared ones are not asserted. tests_user_check_attrs executes the check against a fake id/getent: 5 of 8 rows red before the fix, all green after. Pmat-Ticket: PMAT-618 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
folded into #628 (emergency fold, operator 2026-09-24) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #618. Refs PMAT-618.
The
userresource's check wasid <name>. So a user with the wrong uid, shell, home, primary group or supplementary groups read as converged, and a changed declaration never re-ran. This matters for the lambdacourseuser: its isolation depends on it NOT being innoahorvideo.The check now asserts every declared field against the live account through
verdict::assert_that. Fields that aren't declared aren't asserted. Forgroups, the declared set is compared to the live supplementary set, sorted, deduped, and with the primary group excluded. An extra group diverges, and so does a missing one.tests_user_check_attrs.rsexecutes the generated check against a fakeid/getent. It has 8 rows. Before the fix, 5 were red. After it, all 8 are green; the user tests are 43 green and the full lib is 13561 passed. Clippy is clean.🤖 Generated with Claude Code