ci(nightly): build Windows OpenSSL with Strawberry perl, not msys perl (closes #614) - #640
Merged
Merged
Conversation
closes #614) The windows-msvc leg ran ./Configure under Git's msys perl, which lacks Params::Check, so openssl-sys failed and the all-or-nothing release job skipped: the nightly tag is 11+ days stale and fleet-bins reports NIGHTLY-STALE on every lambda run. OPENSSL_SRC_PERL now names the Strawberry perl windows-latest ships, and the step fails loudly if that perl cannot load the module the build needs. Pmat-Ticket: PMAT-614 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Executes the parsed "Build release binary" step under the shell GitHub uses for `shell: bash`, with stub cargo/cross and a Strawberry perl planted (or withheld) at the path the step names. Windows builds OpenSSL with it and fails before cargo when it is unusable or missing; the Linux, aarch64-cross and macOS legs leave OPENSSL_SRC_PERL unset. Three mutations were measured red: delete the block, drop the probe's exit, make it unconditional. Wired into ci.yml. Pmat-Ticket: PMAT-614 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false) {
"ticket": "PMAT-614",
"head": "f78aef4305bacae8c3ea4750ced7db0d392a9fdb",
"width": 3,
"executor": "agy",
"agreed": false,
"auto_merge": {
"checked": true,
"was_armed": false,
"disarmed": false,
"note": "auto-merge not armed"
},
"lanes": [
{
"lane": 1,
"verdict": "FAIL",
"findings": 1
},
{
"lane": 2,
"verdict": "FAIL",
"findings": 1
},
{
"lane": 3,
"verdict": "FAIL",
"findings": 2
}
]
} |
…and release: 1.33.0 The first commit carried pmat's YAML round-trip: 326 lines reflowed and 68 kind: fields stripped, the regression cb21xx-baseline.json names. All three quorum lanes refuted it. The file is now origin/main plus one entry (22 insertions, 0 deletions), bound to the issue's milestone 1.33.0. Pmat-Ticket: PMAT-614 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
quorum-review (AD-04): three PASS — agreed (auto_merge: checked=true was_armed=false disarmed=false) {
"ticket": "PMAT-614",
"head": "215f2e8a2edffa0e2cacc4109cafd3bee559b30b",
"width": 3,
"executor": "agy",
"agreed": true,
"auto_merge": {
"checked": true,
"was_armed": false,
"disarmed": false,
"note": "auto-merge not armed"
},
"lanes": [
{
"lane": 1,
"verdict": "PASS",
"findings": 4
},
{
"lane": 2,
"verdict": "PASS",
"findings": 0
},
{
"lane": 3,
"verdict": "PASS",
"findings": 4
}
]
} |
Pmat-Ticket: PMAT-614 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…/3 round 1 on the roadmap round-trip) Receipt binds diff_sha256 52ed34bf5b31e6057caf287ac7a762ee9f72cd07 against c1e49a3 and the four PMAT-614 evidence files by blob, sha256 and bytes. Pmat-Ticket: PMAT-614 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly x86_64-pc-windows-msvc leg runs
./Configurefor vendored OpenSSL undershell: bash, which resolves Git's msys perl. That perl lacksParams::Check(BEGIN failed--compilation aborted at /usr/share/perl5/core_perl/Params/Check.pm, run 2026-09-25 09:31Z). openssl-sys fails, the leg is red, and the all-or-nothingreleasejob is skipped. The nightly tag is now 290h behind main, and fleet-bins reports NIGHTLY-STALE on every hourly lambda run.This change sets
OPENSSL_SRC_PERLto the Strawberry perl that windows-latest ships. The step also fails loudly if that perl cannot load the module the build needs, so a future image change stays visible.Not verified before merge: a branch
workflow_dispatchof nightly.yml would publish thenightlyrelease from the branch commit, so I did not dispatch. The first scheduled run after merge is the proof.Pmat-Ticket: PMAT-614
🤖 Generated with Claude Code