Repository navigation
feat: add retry() helper - #2
Closed
NicholasZolton wants to merge 1 commit into
Closed
NicholasZolton wants to merge 1 commit into
NicholasZolton wants to merge 1 commit into
Conversation
| export async function retry<T>(fn: () => Promise<T>, attempts = 3): Promise<T> { | ||
| let lastError: unknown | ||
| for (let i = 0; i < attempts; i++) { | ||
| try { |
There was a problem hiding this comment.
❌ Error handling / no-try-catch
New try/catch block added in a new file. The codebase is migrating to neverthrow; new fallible code should return Result<T, E> instead of using try/catch.
Suggested fix: Refactor to accept a function returning ResultAsync<T, E> and use .orElse() for retries instead of try/catch.
| lastError = e | ||
| } | ||
| } | ||
| throw new Error(`retry failed after ${attempts} attempts: ${String(lastError)}`) |
There was a problem hiding this comment.
❌ Error handling / no-try-catch
New thrown exception added. New fallible functions should return Result<T, E> from neverthrow using err(...)/ok(...) instead of throwing.
Suggested fix: Return err(...) from neverthrow and update the function signature to return Result<T, E> or ResultAsync<T, E>.
Layered ReviewError handling
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small
retry()helper for flaky async operations. Opening this to watch the layered-review agent evaluate it against the repo's neverthrow rule (the helper uses try/catch + throw).