Skip to content

fix(individuality): subscribe a watch again after its subscription fails - #442

Open
BigTava wants to merge 1 commit into
mainfrom
fix/individuality-watch-resubscribe
Open

BigTava wants to merge 1 commit into
mainfrom
fix/individuality-watch-resubscribe

Conversation

@BigTava

@BigTava BigTava commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • watchCurrentGame, watchPlayer and watchParticipant now subscribe again after a failed subscription instead of ending. The failure still goes to onError.
  • PAPI ends a watchValue on its first failed query, so one lost or failed host answer used to silence a watch for good. On jollity-next phones that left the game watch stuck while one-shot reads of the same storage kept working.
  • The wait before the next subscription doubles from one second to thirty and drops back to one second once a value arrives. A value that matches the last one delivered is not delivered again, and stopping the watch cancels a pending resubscription.
  • New tests cover the resubscription, the backoff and a stop during the wait. The first two fail without the change.
  • This pairs with fix(host): answer PAPI when a host call rejects #433, which turns a host call that times out into an error PAPI can see. Without this change, that error would end every SDK watch.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

📦 Bundle size impact

Comparing 2026-10-07T09:19:10.549Z → 2026-10-07T09:18:24.543Z

Package Entry Bundled before Bundled after Δ Ship gzip Δ Shake ratio
🟢 @parity/product-sdk ./individuality 85.1 KB 85.2 KB +111 B (+0.1%) 0 B —

Thresholds — 🟡 ≥10% or ≥5.0 KB · 🟠 ≥20% or ≥15.0 KB (bundled). Percentage only applies once the baseline is ≥ 10 KB. Informational — this check never blocks merge.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant