Skip to content

truapi-server: golden_rust_emit test races on target/doc/truapi.json and silently passes without nightly #99

Closed

Description

@pgherveou

Found during review of #96. rust/crates/truapi-codegen/tests/golden_rust_emit.rs writes/reads the same workspace target/doc/truapi.json path concurrently when cargo test parallelizes, and silently returns success when cargo +nightly rustdoc is unavailable (eprintln! + return). On a no-nightly CI the test is vacuously green. Fix: serialize the two tests (per-test tempdir) and either gate them behind a nightly/expensive feature or fail-loud when nightly is missing.

Activity

  1. pgherveou commented on Jun 29, 2026

    @pgherveou
    CollaboratorAuthor

    Closing this generated tracking issue as covered by PR #104 and its review follow-ups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions