Repository navigation
feat(truapi): pay withdrawals into their account as getcash does - #1228
Closed
filvecchiato wants to merge 1 commit into
Closed
filvecchiato wants to merge 1 commit into
filvecchiato wants to merge 1 commit into
Conversation
Contributor
Bundle size reportCompared with
WebAssembly modules
Changed files (10)
Commit: bda3d56 |
Contributor
|
CI Status: not green, 1 item needs attention.
All job results
Signing credentials: failure as of 2026-10-06, a release may fail Commit |
Collaborator
Author
|
Consolidated into #1232, which carries these commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The payment leg of a withdrawal, as getcash pays its withdrawal key (main c63202a6):
wd:eph:<dest>:<n>, counter perwd:<dest>assign_funding_withdrawal: same label under the funding product, counterwd:<dest>, skipping accounts that hold CASH on Peoplefunding_attempt_id, shared with top-upsAlreadyExistsis success, other errors failPaymentPlatform(#1227) as the funding product; a refusal ends the session for a retryPaidpaymentTakenfrom the latest status; never expires or cancelsretry_funding, while the account is still read (72 h), so CASH that arrived is never asked for twiceDifferences: the host's
Completedmarks the payment taken but the session waits for the CASH on the account before it isPaid. APaidsession is converted and sent on in the next PR.Part of #1179