Skip to content

chore: clean up host code and protect SSO secrets - #1356

Open
pgherveou wants to merge 5 commits into
mainfrom
chore/account-holder-prep
Open

pgherveou wants to merge 5 commits into
mainfrom
chore/account-holder-prep

Conversation

@pgherveou

@pgherveou pgherveou commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator
  • Use canonical truapi::latest payload imports and direct test imports.
  • Add zeroization on drop and secret-redacted Debug derives to existing SSO types.
  • Simplify comments and expressions across the host code.
  • Enforce Polkadot SDK Rust formatting with edition 2024 and JS host Prettier rules in CI, including Rust runtime modules declared inside macros.

@pgherveou pgherveou added the no-changeset No published artifact changes; changeset not required label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

This pull request touches an app, which is not built by default. Add a label for each build you want:

  • iOS simulator build, ios-simulator-build: builds the iOS app, runs its tests and attaches a build for the iOS Simulator on a Mac.
  • iOS device build, ios-device-build: attaches a signed build that installs on a registered iPhone or iPad.
  • Android build, android-device-build: attaches an APK that installs on an Android phone or an emulator.

Each starts as soon as it is added and follows the branch from then on.

@github-actions github-actions Bot added documentation Improvements or additions to documentation javascript Pull requests that update javascript code rust Pull requests that update rust code host-ios Touches the iOS host tree host-android Touches the Android host tree labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Bundle size report

Compared with main at 6843c76.

Raw Gzip Brotli
truapi-host 7.85 MiB (+438 B) 5.65 MiB (+233 B) 5.38 MiB (+1019 B)
truapi-provider 4.03 MiB 1.27 MiB (-1 B) 960.2 KiB (+365 B)
truapi 6.01 MiB 849.3 KiB 695.9 KiB
Total 17.89 MiB (+438 B) 7.75 MiB (+232 B) 6.99 MiB (+1.4 KiB)

WebAssembly modules

Raw Gzip Brotli
truapi-host/wasm/web/truapi_server_bg.wasm 2.74 MiB (+438 B) 978.2 KiB (+237 B) 738.2 KiB (+1.0 KiB, +0.1%)
truapi-host/wasm/web/truapi_verifiable_bg.wasm 4.89 MiB 4.64 MiB 4.61 MiB
truapi-provider/truapi_provider_bg.wasm 3.99 MiB 1.26 MiB (-1 B) 952.4 KiB (+365 B)
Changed files (1)
Raw Gzip Brotli
truapi-host/wasm/web/truapi_server_bg.wasm 2.74 MiB (+438 B) 978.2 KiB (+237 B) 738.2 KiB (+1.0 KiB, +0.1%)

Commit: 00e078c

@pgherveou pgherveou removed the no-changeset No published artifact changes; changeset not required label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

CI Status: not green, 3 items need attention.

  • rust: failure
  • ts-host: failure
  • host-wasm: failure
All job results
job result
android-bindings success
bundle-size success
changes success
changeset-guard success
cli-package success
codegen success
e2e skipped
explorer success
headless-install success
host-android-bindings success
host-android-detekt success
host-wasm failure
ios-bindings success
ios-swift success
licenses success
playground success
provider-android-bindings success
release-guard success
rust failure
ts-client success
ts-debugger success
ts-host failure
wasm-provider success
workflow-lint success

Signing credentials: failure as of 2026-10-09, a release may fail

Commit 00e078c8 · run log

@pgherveou pgherveou changed the title chore: prepare account-holder refactor chore: clean up host code and protect SSO secrets Oct 9, 2026
@pgherveou
pgherveou marked this pull request as ready for review October 9, 2026 10:02
@pgherveou
pgherveou requested a review from a team October 9, 2026 10:02
@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code host-android Touches the Android host tree host-ios Touches the iOS host tree javascript Pull requests that update javascript code rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant