Skip to content

test(e2e): run the CLI e2e scenarios from e2e/cli through one make target - #1595

Open
decrypto21 wants to merge 1 commit into
mainfrom
test/e2e-cli-scenarios
Open

decrypto21 wants to merge 1 commit into
mainfrom
test/e2e-cli-scenarios

Conversation

@decrypto21

@decrypto21 decrypto21 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Every new CLI e2e script added another one-line e2e-* target to the root Makefile. The scripts now live in e2e/cli/, one per scenario, and a single make e2e-cli target finds them, so adding a scenario means adding a file.

Changes

  • Move scripts/battery.sh, scripts/cross-product-*-e2e.sh, scripts/preimage-submit-prompt-e2e.sh, scripts/trusted-device-permission-e2e.sh and scripts/chain-head-failure-cause-e2e.sh to e2e/cli/ (dropping the -e2e suffix); each still runs from anywhere.
  • Replace e2e-signing-cli, e2e-pairing-cli, e2e-chat-cli, e2e-pocket-cli, e2e-funding-cli, e2e-cross-product, e2e-preimage-submit-prompt, e2e-trusted-device-permission and e2e-chain-head-failure-cause with make e2e-cli SCENARIO=<name> [ARGS=...]. With no SCENARIO it lists the scenarios; it only runs names it discovered.
    • make e2e-signing-cli → e2e/cli/battery.sh --signing-host or make e2e-cli SCENARIO=battery ARGS=--signing-host (likewise for the other battery phases)
    • make e2e-cross-product SCENARIO=storage → make e2e-cli SCENARIO=cross-product-storage
  • Targets with real make dependencies (e2e-dotli, e2e-cli-diagnosis, e2e-cli-update, e2e-host-playground-*) stay.
  • Add e2e/cli/README.md with the add-a-file convention, and repoint README, AGENTS.md, the CLI README and SPEC, and source comments.
  • battery.sh --help now works when invoked by a relative path from another directory, and lists --chat-host and --product-id.

No CI job calls these scripts, and nothing published changes.

Testing

  • make e2e-cli lists the nine scenarios; an unknown or path-like SCENARIO fails.
  • make e2e-cli SCENARIO=cross-product-statement-proof passes end to end.
  • make e2e-cli SCENARIO=chain-head-failure-cause passes end to end.
  • shellcheck -S warning e2e/cli/*.sh is clean.

Closes #1462

@decrypto21
decrypto21 requested a review from a team October 21, 2026 10:47
@decrypto21 decrypto21 added the no-changeset No published artifact changes; changeset not required label Oct 21, 2026
@github-actions github-actions Bot added documentation Improvements or additions to documentation javascript Pull requests that update javascript code rust Pull requests that update rust code labels Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Bundle size report

Compared with main at afc8594.

Raw Gzip Brotli
truapi-host 8.07 MiB 5.72 MiB 5.43 MiB
truapi-provider 4.03 MiB 1.27 MiB 960.2 KiB
truapi 6.72 MiB 950.2 KiB 776.8 KiB
trinity-stack 562.4 KiB 225.5 KiB 186.6 KiB
Total 19.37 MiB 8.14 MiB 7.31 MiB

WebAssembly modules

Raw Gzip Brotli
truapi-host/wasm/web/truapi_server_bg.wasm 2.96 MiB 1.03 MiB 789.0 KiB
truapi-host/wasm/web/truapi_verifiable_bg.wasm 4.89 MiB 4.64 MiB 4.61 MiB
truapi-provider/truapi_provider_bg.wasm 3.99 MiB 1.26 MiB 952.5 KiB
trinity-stack/wasm/trinity_stack_bg.wasm 525.1 KiB 217.1 KiB 179.3 KiB

No file changed size.

Commit: 8d27894

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

CI Status: 25 required jobs green, 23 passed and 2 skipped by path filter.

All job results
job result
android-bindings success
bundle-size success
changes success
changeset-guard success
cli-package success
codegen success
e2e skipped
explorer success
headless-install success
host-android-bindings success
host-android-detekt success
host-wasm success
ios-bindings success
ios-swift success
licenses success
playground success
provider-android-bindings success
release-guard success
rust success
ts-client success
ts-debugger success
ts-host success
ts-trinity-stack success
wasm-provider success
workflow-lint skipped

Signing credentials: valid as of 2026-10-26

Commit 8d278948 · run log

…rget

The CLI e2e scripts move from scripts/ to e2e/cli/, one script per scenario, and the seven one-line Makefile targets that wrapped them become a single `make e2e-cli SCENARIO=<name> [ARGS=...]` that discovers e2e/cli/*.sh. A new scenario is a new file, not a new target.

Closes #1462
@decrypto21
decrypto21 force-pushed the test/e2e-cli-scenarios branch from 2acd7eb to 8d27894 Compare October 26, 2026 12:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation javascript Pull requests that update javascript code no-changeset No published artifact changes; changeset not required rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

standardize e2e script in the makefile

2 participants