Repository navigation
test(e2e): run the CLI e2e scenarios from e2e/cli through one make target - #1595
Open
decrypto21 wants to merge 1 commit into
Open
decrypto21 wants to merge 1 commit into
decrypto21 wants to merge 1 commit into
Conversation
Contributor
Bundle size reportCompared with
WebAssembly modules
No file changed size. Commit: 8d27894 |
Contributor
|
CI Status: 25 required jobs green, 23 passed and 2 skipped by path filter. All job results
Signing credentials: valid as of 2026-10-26 Commit |
…rget The CLI e2e scripts move from scripts/ to e2e/cli/, one script per scenario, and the seven one-line Makefile targets that wrapped them become a single `make e2e-cli SCENARIO=<name> [ARGS=...]` that discovers e2e/cli/*.sh. A new scenario is a new file, not a new target. Closes #1462
decrypto21
force-pushed
the
test/e2e-cli-scenarios
branch
from
October 26, 2026 12:57
2acd7eb to
8d27894
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every new CLI e2e script added another one-line
e2e-*target to the root Makefile. The scripts now live ine2e/cli/, one per scenario, and a singlemake e2e-clitarget finds them, so adding a scenario means adding a file.Changes
scripts/battery.sh,scripts/cross-product-*-e2e.sh,scripts/preimage-submit-prompt-e2e.sh,scripts/trusted-device-permission-e2e.shandscripts/chain-head-failure-cause-e2e.shtoe2e/cli/(dropping the-e2esuffix); each still runs from anywhere.e2e-signing-cli,e2e-pairing-cli,e2e-chat-cli,e2e-pocket-cli,e2e-funding-cli,e2e-cross-product,e2e-preimage-submit-prompt,e2e-trusted-device-permissionande2e-chain-head-failure-causewithmake e2e-cli SCENARIO=<name> [ARGS=...]. With noSCENARIOit lists the scenarios; it only runs names it discovered.make e2e-signing-cli→e2e/cli/battery.sh --signing-hostormake e2e-cli SCENARIO=battery ARGS=--signing-host(likewise for the other battery phases)make e2e-cross-product SCENARIO=storage→make e2e-cli SCENARIO=cross-product-storagee2e-dotli,e2e-cli-diagnosis,e2e-cli-update,e2e-host-playground-*) stay.e2e/cli/README.mdwith the add-a-file convention, and repoint README, AGENTS.md, the CLI README and SPEC, and source comments.battery.sh --helpnow works when invoked by a relative path from another directory, and lists--chat-hostand--product-id.No CI job calls these scripts, and nothing published changes.
Testing
make e2e-clilists the nine scenarios; an unknown or path-likeSCENARIOfails.make e2e-cli SCENARIO=cross-product-statement-proofpasses end to end.make e2e-cli SCENARIO=chain-head-failure-causepasses end to end.shellcheck -S warning e2e/cli/*.shis clean.Closes #1462