Chore/community merge#298
Merged
Merged
Conversation
…itor
Wholesale swap of packages/{core,viewer,editor,mcp} and apps/editor with the
versions from the private editor repo, which is the production source of truth.
Setup changes:
- packages/{core,viewer,editor} versions held at 0.7.0 baseline (matching
the most recent published release) so a bump=minor publishes 0.8.0
- packages/mcp held at 0.1.1 (never published; first publish will go through
the new release.yml flow)
- peerDependencies and devDependencies for inter-package @pascal-app/*
references pinned to ^0.7.0 instead of '*' / 'workspace:*' so they are
valid for npm consumers
- Root package.json: TypeScript bumped to 6.0.2, added overrides for
@types/react, @types/react-dom, @types/three to prevent JSX namespace
fragmentation across the workspace
- release.yml extended to also publish editor and mcp; 'both' option renamed
to 'all'; added a sync step that updates inter-package peerDeps/devDeps to
match the new versions on every bump (so viewer/editor/mcp tarballs always
reference the version of core they were built against)
- Root scripts gained release:editor and release:mcp shortcuts
Verification:
- bun install --frozen-lockfile is consistent
- packages/{core,viewer,mcp} build cleanly, dist/index.d.ts emitted
- packages/editor check-types reports 21 pre-existing errors, identical to
what private-editor currently reports
Open PRs against editor-v2 will need rebasing/conflict resolution.
Real root cause: Tailwind v4's lightningcss is invoked from a Turbopack-bundled postcss.js at runtime. Turbopack resolves require() against the workspace's TOP-LEVEL node_modules, not against bun's nested .bun/ store. So even when lightningcss-darwin-arm64 is correctly installed inside .bun/ with proper symlinks, Turbopack can't see it — and lightningcss falls back to a sibling '.node' file which doesn't exist, hence the runtime error. Private-editor accidentally works because it has TWO lightningcss versions (1.27.0 from Expo + 1.32.0 from Tailwind), which forces bun's hoisting algorithm to put one copy at the top level. Editor-v2 has only one version, so bun keeps it nested in .bun/ and nothing is at top-level. Fix: declare the platform binary packages as optionalDependencies at the WORKSPACE ROOT (not apps/editor). Root deps are always hoisted to top-level node_modules, so Turbopack's resolver finds them. Bun still applies the os/cpu filter at install time, so each developer only ends up with their host's binaries on disk. Verified on Linux: node_modules/lightningcss-linux-arm64-gnu is a top-level symlink after install. On macOS, the darwin variants will be hoisted instead.
apps/editor/app/globals.css imports '../../../styles/elevation.css', a shared
elevation/shadow utility set used across both private-editor's apps and the
public editor-v2 apps/editor. Was missing from this repo because the swap
covered packages/{core,viewer,editor,mcp} and apps/editor but not the
top-level styles/ directory.
Copied verbatim from private-editor.
Lockfile dedup pass after running bun install on macOS — picks up the darwin-arm64 native binaries hoisted to top-level node_modules and removes a redundant cmdk@radix nested resolution edge that wasn't needed.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bring community updates into open-source version