Skip to content

Get low scoped access token - #328

Merged
kgangineni merged 2 commits into
feature/app_switchfrom
createAccessToken
Jul 7, 2025
Merged

Get low scoped access token#328
kgangineni merged 2 commits into
feature/app_switchfrom
createAccessToken

Conversation

@kgangineni

@kgangineni kgangineni commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

Summary of changes

  • Get access token using client id
  • Use it in PaypalWebCheckoutClient
  • Token is not used right now, added todo to be used in getting app switch eligibility

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@kgangineni
⏺ Add OAuth2 client token fetching with suspend PayPalWebCheckoutClient
387de57 
  - Implement FetchClientToken class for OAuth2 client credentials flow
  - Add headers parameter to APIRequest for Basic auth support
  - Convert PayPalWebCheckoutClient.start() to suspend function
  - Integrate token fetching before launching web checkout
  - Add comprehensive error handling for token fetch failures
@kgangineni
kgangineni requested a review from a team as a code owner June 25, 2025 16:03
sshropshire
sshropshire reviewed Jun 25, 2025
View reviewed changes
Comment thread CorePayments/src/main/java/com/paypal/android/corepayments/api/FetchClientToken.kt Outdated
sshropshire
sshropshire reviewed Jun 25, 2025
View reviewed changes
Comment thread CorePayments/src/main/java/com/paypal/android/corepayments/api/FetchClientToken.kt Outdated
sshropshire
sshropshire reviewed Jun 25, 2025
View reviewed changes
Comment thread CorePayments/src/main/java/com/paypal/android/corepayments/api/FetchClientToken.kt Outdated
sshropshire
sshropshire reviewed Jun 25, 2025
View reviewed changes
Comment thread CorePayments/src/main/java/com/paypal/android/corepayments/api/FetchClientToken.kt Outdated
@kgangineni
kgangineni force-pushed the createAccessToken branch 3 times, most recently from 754dd35 to cdbf235 Compare July 1, 2025 16:14
sshropshire
sshropshire reviewed Jul 3, 2025
View reviewed changes
Comment thread CorePayments/src/main/java/com/paypal/android/corepayments/APIClientError.kt Outdated
sshropshire
sshropshire reviewed Jul 3, 2025
View reviewed changes
Comment thread CorePayments/src/main/java/com/paypal/android/corepayments/api/GetClientTokenResult.kt Outdated
sshropshire
sshropshire approved these changes Jul 3, 2025
View reviewed changes

@sshropshire sshropshire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple take or leave 🧶 's but overall LGTM

@kgangineni
kgangineni force-pushed the createAccessToken branch from cdbf235 to ece60f6 Compare July 7, 2025 18:26
@kgangineni
⏺ Add callback-based start function with PayPalWebCheckoutCallback in…
cf9bece 
…terface

  - Create PayPalWebCheckoutCallback fun interface following CardApproveOrderCallback pattern
  - Add overloaded start() function accepting PayPalWebCheckoutCallback
@kgangineni
kgangineni force-pushed the createAccessToken branch from ece60f6 to cf9bece Compare July 7, 2025 18:36
@kgangineni
kgangineni merged commit 39de947 into feature/app_switch Jul 7, 2025
@kgangineni
kgangineni deleted the createAccessToken branch July 7, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sshropshire sshropshire sshropshire approved these changes
+1 more reviewer
@KunJeongPark KunJeongPark KunJeongPark left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kgangineni @KunJeongPark @sshropshire