Repository navigation
refactor: remove lint suppressions the code no longer needs - #192
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
pedroapfilho
force-pushed
the
chore/lint-disables
branch
from
October 19, 2026 17:12
1529727 to
b3d0c09
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directives: 29 before, 10 after. 20 removed, 1 added, 9 kept.
Removed:
no-console:@dashfoo/corenow exportswarnandwarnOnce(packages/core/src/lib/warn.ts), which hold the one remainingno-consoledisable. Core and react both report through it; react'slib/warn-once.tsis gone, and the missing-component warning useswarnOnceinstead of its own set.typescript/no-deprecatedin docs: replaced the deprecatedsearch.options.type: "static"preset with aSearchDialogbuilt onstaticClient+useDocsSearch, the fumadocs-documented successor.typescript/no-unnecessary-conditiononhasPointerCapture?.(): the gesture already callssetPointerCaptureunguarded, so the guard only served jsdom. Tests stubhasPointerCaptureinstead.scripts/launch/consumer-runtime.mjs.fixture: oxlint never lints a.fixturefile, so they suppressed nothing.Kept, by constraint:
Register(demo-vite).setup({ types })takes phantom{} as Tvalues (3, drag-dock machine).parseModel(value: unknown)is the validation boundary itself;useLayoutStorage'srestoreis a hook callback, not a child component passing data up;export {}is what makesstyles.css.d.tsa module; the landing code panel is a scrollable region that needstabIndex={0}to be keyboard-scrollable; the landing theme script needs raw inline HTML to run before first paint.Changeset:
@dashfoo/coreminor (newwarn/warnOnceexports),@dashfoo/reactpatch. No package bumps.Verification:
pnpm build --filter="./packages/*" && pnpm exec oxlint --report-unused-disable-directives-severity=error .: cleanpnpm lint:launch,pnpm typecheck,pnpm test,pnpm format:check,pnpm fallow:dead: passpnpm --filter docs build: pass