Skip to content

refactor: remove lint suppressions the code no longer needs - #192

Merged
pedroapfilho merged 1 commit into
mainfrom
chore/lint-disables
Oct 19, 2026
Merged

pedroapfilho merged 1 commit into
mainfrom
chore/lint-disables

Conversation

@pedroapfilho

Copy link
Copy Markdown
Owner

Directives: 29 before, 10 after. 20 removed, 1 added, 9 kept.

Removed:

  • 16 no-console: @dashfoo/core now exports warn and warnOnce (packages/core/src/lib/warn.ts), which hold the one remaining no-console disable. Core and react both report through it; react's lib/warn-once.ts is gone, and the missing-component warning uses warnOnce instead of its own set.
  • typescript/no-deprecated in docs: replaced the deprecated search.options.type: "static" preset with a SearchDialog built on staticClient + useDocsSearch, the fumadocs-documented successor.
  • typescript/no-unnecessary-condition on hasPointerCapture?.(): the gesture already calls setPointerCapture unguarded, so the guard only served jsdom. Tests stub hasPointerCapture instead.
  • 2 file-level disables in scripts/launch/consumer-runtime.mjs.fixture: oxlint never lints a .fixture file, so they suppressed nothing.

Kept, by constraint:

  • Interface declaration merging: TanStack Router Register (demo-vite).
  • Library API shape: XState setup({ types }) takes phantom {} as T values (3, drag-dock machine).
  • Rule misfiring on a valid construct: parseModel(value: unknown) is the validation boundary itself; useLayoutStorage's restore is a hook callback, not a child component passing data up; export {} is what makes styles.css.d.ts a module; the landing code panel is a scrollable region that needs tabIndex={0} to be keyboard-scrollable; the landing theme script needs raw inline HTML to run before first paint.

Changeset: @dashfoo/core minor (new warn/warnOnce exports), @dashfoo/react patch. No package bumps.

Verification:

  • pnpm build --filter="./packages/*" && pnpm exec oxlint --report-unused-disable-directives-severity=error .: clean
  • pnpm lint:launch, pnpm typecheck, pnpm test, pnpm format:check, pnpm fallow:dead: pass
  • pnpm --filter docs build: pass

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dashfoo-demo-vite Ready Ready Preview Oct 19, 2026 5:16pm UTC
dashfoo-docs Ready Ready Preview Oct 19, 2026 5:16pm UTC
dashfoo-landing Ready Ready Preview Oct 19, 2026 5:16pm UTC

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit b3d0c09.

This branch was successfully deployed

3 active deployments
Preview – dashfoo-landing — b3d0c092 Deployed Oct 19, 2026 by vercel[bot]
Preview – dashfoo-docs — b3d0c092 Deployed Oct 19, 2026 by vercel[bot]
Preview – dashfoo-demo-vite — b3d0c092 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant