[BUGFIX] Table cell settings#645
Open
mixturesolutions wants to merge 2 commits intoperses:mainfrom
Open
Conversation
mixturesolutions
force-pushed
the
snapshot/table-fix-test
branch
3 times, most recently
from
f1555e2 to
8dcea73
Compare
- gauge chart fixed in cell - gauge chart colors aligned with cell settings - range function debugged to allow only number (letters except e(used as scientific notation) cannot be entered instead of returning NaN) - range function allow decimals not just integers Signed-off-by: Iris Ye <iris.ye@sap.com>
mixturesolutions
force-pushed
the
snapshot/table-fix-test
branch
from
8dcea73 to
8af9e34
Compare
ibakshay
reviewed
May 6, 2026
Contributor
ibakshay
left a comment
ibakshay
left a comment
There was a problem hiding this comment.
Thank you for the PR! Looks solid. left a small comment.
ibakshay
reviewed
May 6, 2026
| /> | ||
| </Box> | ||
| <Typography variant="body2" sx={{ minWidth: 52, textAlign: 'right' }}> | ||
| {value.toFixed(2)} ms |
Contributor
There was a problem hiding this comment.
Please remove the hard-coded ms unit. The unit should come from the column setting.
Author
There was a problem hiding this comment.
Thank you Akshay for the review. Newest commit should solve the issue.
mixturesolutions
force-pushed
the
snapshot/table-fix-test
branch
from
3730c3a to
8af9e34
Compare
…ith Gauge units aligning to column format Signed-off-by: Iris Ye <iris.ye@sap.com>
ibakshay
requested changes
May 8, 2026
| value={gaugeValue} | ||
| range={gaugeRange} | ||
| fillColor={gaugeFillColor} | ||
| format={column.format} |
Contributor
There was a problem hiding this comment.
Currently, there is no effect in the embedded Gauge panel, when I change the unit in the drop down. with this change, the unit will be reflected as well.
Suggested change
| format={column.format} | |
| format={plugin.spec?.format ?? column.format} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes/implements the proposals from this open issue
Screenshots
Prev:
With PR:
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes