Repository navigation
fix(proxysql): resync satellites stuck on core DNS - #193
Open
sideshowbandana wants to merge 1 commit into
Open
sideshowbandana wants to merge 1 commit into
sideshowbandana wants to merge 1 commit into
Conversation
Satellites that keep hostname proxysql-core after a core rotation never counted as missing, so the existing resync path never ran. Count that DNS peer when last_check_ms is stale so we reload proxysql_servers from config. **Potential Risk** Satellites may reload proxysql_servers more often when the DNS peer is stale (~30s). Reload is the same path ops use by hand. A bug in the SQL could skip legitimate IP-core missing detection. Worst Case Incident: SEV-3 **AI Usage** Cursor agent implemented from the approved plan; reviewer should check the stats query and sqlmock. **Testing Strategy** go test ./internal/proxysql/ -count=1 -run 'TestGetMissingCorePods|TestSatelliteResync'
Contributor
Author
|
Verify that this is actually a change that we want and need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxysql-coreService DNS peers in GetMissingCorePods so SatelliteResync reloads proxysql_servers from config.Test plan