Skip to content

fix: accept Codex batch JSON with token footer #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szupzj18 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: accept Codex batch JSON with token footer #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion desloppify/app/commands/review/runner_process_impl/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ def _output_file_has_json_payload(output_file: Path) -> bool:
if not output_file.exists():
return False
try:
payload = json.loads(output_file.read_text(encoding="utf-8", errors="replace"))
text = output_file.read_text(encoding="utf-8", errors="replace").lstrip()
payload, _ = json.JSONDecoder().raw_decode(text)
except (OSError, json.JSONDecodeError):
return False
return isinstance(payload, dict)
Expand Down
5 changes: 5 additions & 0 deletions desloppify/tests/review/test_runner_internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ def test_valid_json_dict(self, tmp_path):
p.write_text('{"assessments": {}}')
assert _output_file_has_json_payload(p) is True

def test_valid_json_dict_with_codex_token_footer(self, tmp_path):
p = tmp_path / "out.json"
p.write_text('{"assessments": {}, "issues": []}\ntokens used\n1,234')
assert _output_file_has_json_payload(p) is True

def test_json_array_rejected(self, tmp_path):
p = tmp_path / "out.json"
p.write_text("[1, 2, 3]")
Expand Down