fix: recognize CommonJS require calls in JS/TS import graph - #720
Open
szupzj18 wants to merge 1 commit into
Open
fix: recognize CommonJS require calls in JS/TS import graph#720szupzj18 wants to merge 1 commit into
szupzj18 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JS_SPEC.import_query(andTYPESCRIPT_SPEC) only matches ESMimport_statement, so a CommonJSrequire('./module')call produces no import edge. Files imported only viarequireare reported with zero importers and show up as falseorphanedfindings. This is the second half of #715; #696 fixes the relative/absolute path-space mismatch in the same graph builder.Fix
Add a second pattern to the JS/TS import query that matches
require()calls, using an#eq?predicate so other calls with string arguments are not treated as imports:resolve_js_importalready skips bare package names, sorequire('lodash')does not create an edge.Test
test_js_dep_graph_includes_commonjs_requirebuilds a graph for a file with a relativerequire, a packagerequire, and a non-require call, and asserts only the relative edge is kept. Fails without the query change, passes with it.