Restore Webmention forms on block themes and hide classic-only checkbox - #672
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release archives excluded
build/form/block.jsonthrough the/build/*/block.jsonexport-ignore rule. Without that metadata, WordPress cannot register or automatically insert the Webmention Form block, while block themes skip the classic form. This leaves no Webmention form even when the checkbox is enabled. On notiz.blog, the metadata URL returns 404 while the form JavaScript returns 200.Include the form block metadata in release archives and only skip the classic form when the form block is registered. Other build-entry metadata stays excluded.
Hide the "Show a Webmention form" checkbox only on block themes and ignore its saved value when using Block Hooks. Classic themes retain the checkbox and its behavior; the custom help-text field remains. The form block can be moved or removed in the Site Editor.
Validation:
git archive HEAD build/formincludesbuild/form/block.json.git diff --checkpass.sourceelement under PHPUnit 9.Follow-up to #667.