Repository navigation
Fix Webmention button padding for translated labels - #673
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Webmention submit input squeezes the theme’s right padding around translated text on notiz.blog. Render it as a submit button so its content and theme padding determine its width naturally. No fixed width or height is added. Preserve the translated label, submit-text filter, classes, ID, and submitted name/value.
Extend the URL field label to "Replied on your own website? Enter the URL of your post to let me know:" in both the frontend and editor preview, and rebuild the form assets.
Validation: compared the input and replacement button in a browser on notiz.blog without submitting a Webmention; the button accommodates the translated text and existing 20px padding on each side. Build, JS lint, PHP coding checks, and all 13 form tests pass.