Skip to content

Keep form toggle available when Block Hooks are unused - #676

Merged
pfefferle merged 1 commit into
mainfrom
fix/form-toggle-without-block-hooks
Oct 5, 2026
Merged

pfefferle merged 1 commit into
mainfrom
fix/form-toggle-without-block-hooks

Conversation

@pfefferle

Copy link
Copy Markdown
Owner

Block themes on WordPress 6.2–6.3 use the classic Webmention form because Block Hooks are unavailable, but the settings screen hides its enable/disable checkbox. Show the checkbox whenever webmention_use_block_hooks() is false, matching the actual form rendering decision. This also preserves control when a filter disables hooks or the form block is unregistered.

Regression coverage checks checkbox visibility with a missing form block and with hooks disabled in a block theme. Existing coverage verifies the checkbox stays hidden when hooks are active.

Validation: final manual review found no additional issue in this change; PHP coding standards, PHP syntax, and diff checks passed; all 47 JavaScript tests passed. Local PHP tests could not run because the WordPress/ClassicPress test library is missing. The existing CI matrix includes WordPress 6.2.

@pfefferle
pfefferle merged commit 745763b into main Oct 5, 2026
4 of 8 checks passed
@pfefferle
pfefferle deleted the fix/form-toggle-without-block-hooks branch October 5, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant