Skip to content

Normalize role name during fingerprinting - #357

Open
duckinator wants to merge 4 commits into
pganalyze:18-latestfrom
duckinator:normalize-role-name
Open

Normalize role name during fingerprinting#357
duckinator wants to merge 4 commits into
pganalyze:18-latestfrom
duckinator:normalize-role-name

Conversation

@duckinator

@duckinator duckinator commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This makes fingerprints the following commands/statements ignore role names:

  • CREATE ROLE
  • ALTER ROLE
  • DROP ROLE
  • GRANT
  • REASSIGN OWNED BY
  • ALTER TABLE ALL IN TABLESPACE [...] OWNED BY role_name [...]

@duckinator
duckinator marked this pull request as ready for review August 6, 2026 15:19
@duckinator

duckinator commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@seanlinsley @lfittl this should handle #336. However, ALTER TABLE ALL IN TABLESPACE [...] OWNED BY role_name [...] (postgres docs) is also affected, despite not being mentioned in #336.

If that's acceptable/wanted, this PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant