chore(phel): track dev-main for assert-expr p/thrown? compat#17
Merged
Conversation
v0.40.0 release predates the phel.test/assert-expr signature change (arg order flipped to [message form], dispatch on 2nd arg) that the suite's portability p/thrown? shim depends on, so the tag fails to compile string/core tests. Pin dev-main to match the nightly CI target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
v0.40.0release predates thephel.test/assert-exprsignature change that the suite'sp/thrown?portability shim depends on:(defmethod assert-expr 'thrown? [form message] ...)— arg order[form message], dispatch on 1st arg.(defmethod assert-expr 'thrown? [message form] ...)— arg order[message form], dispatch on 2nd arg (Clojure-compatible).test/clojure/core_test/portability.cljc(:phelbranch, jank-lang#897) is written to the new[message form]contract. Onv0.40.0the namespacedp/thrown?defmethod never registers →[PHEL001] Cannot resolve symbol 'p/thrown?'→ string/core tests fail to compile.What
Pin
phel-lang/phel-langtodev-main(withminimum-stability: dev+prefer-stable: true) so the suite matches the nightly CI target instead of a stale stable tag.Verification
Compile errors gone. Remaining 23 failures are pre-existing type-strictness diffs (
p/thrown?onnil/non-string — phel tolerates, Clojure JVM throws), not string-logic bugs.