Repository navigation
Feature/phi imf efficiency - #778
daymontas1 wants to merge 21 commits into
Conversation
|
First steps:
|
LaviniaBaumstark
left a comment
LaviniaBaumstark
left a comment
There was a problem hiding this comment.
if this PR is o.k., it can be merged independently of the REMIND-PR. Additional inptu data files can behandled (are ignored) by our input data workflow
|
This PR still contains files that should not be added, namely |
|
|
||
| # ------------------------------------------------------------ | ||
| # Manual overrides for specific regions | ||
| # ------------------------------------------------------------ |
There was a problem hiding this comment.
What does this comment mean? Looks to me like a leftover of AI generated code. Please remove.
| calcPHI <- function() { | ||
|
|
||
| output <- readSource("IMF_PHI") | ||
|
|
There was a problem hiding this comment.
add this line
getNames(output) <- NULL
this avoids the useless column value in the output file
CAZ,value,0.8233030245275
| # ------------------------------------------------------------ | ||
| # Clean numeric columns | ||
| # ------------------------------------------------------------ | ||
| raw_clean <- raw %>% |
There was a problem hiding this comment.
This is not necessary in your data, read in data is already in numeric format.
|
The unwanted files still exist in the repository. Unfortunately, just deleting them and adding a new commit won't be enough, as the files are extremely large and will clutter the git history, even if we delete them with a commit. So the solution should be:
|
| return(as.magpie(phi_region)) | ||
|
|
||
| } | ||
| return(as.magpie(phi_region)) |
There was a problem hiding this comment.
this code is syntactically incorrect. looks like a merge error
| #' @author Diamantis Koutsandreas | ||
|
|
||
| #' @noRd | ||
| utils::globalVariables(c("value", "min_val", "reg", "tewacc")) |
There was a problem hiding this comment.
should not be used. if you get warnings for unknown variables, there are other ways to deal with them . in your case, there should be no problems with this list of variables as is.
|
Closing in favor of #822 which is clean from unwanted files. |
3 participants
This PR introduces the input data for the new realization investment inefficiencies in the macro module (Available here: remindmodel/remind#2278).